After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693586 - Erroneous focus claims resulting from gtk_notebook_set_current_page()
Erroneous focus claims resulting from gtk_notebook_set_current_page()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Accessibility
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-02-11 12:44 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-10-06 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test case (2.22 KB, text/plain)
2013-02-11 12:44 UTC, Joanmarie Diggs (IRC: joanie)
  Details
a11y: Drop obsolete focus tab handling in notebooks (5.62 KB, patch)
2013-02-13 03:36 UTC, Matthias Clasen
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-02-11 12:44:05 UTC
Created attachment 235696 [details]
test case

Steps to reproduce:
1. Launch the attached test case.
2. Press Space to activate the '+' button.

Expected results: The accessible page tab associated with the GtkNotebook would not make any claim of having focus because the GtkButton has focus.

Actual results: Each time the '+' button is activated, the accessible page tab associated with the GtkNotebook claims focus.
Comment 1 Matthias Clasen 2013-02-13 03:36:51 UTC
Created attachment 235863 [details] [review]
a11y: Drop obsolete focus tab handling in notebooks

GtkNotebook lost the concept of a separate 'focus tab' ages ago.
Time for the accessible implementation to follow suit.
Comment 2 Matthias Clasen 2013-02-13 03:38:05 UTC
Can you check if this patch helps ? I'm having some trouble running your python test against my jhbuild gtk, so it would be good to have you confirm that a) this fixes the focus issue and b) it doesn't break notebook a11y otherwise.
Comment 3 Matthias Clasen 2013-10-06 06:12:53 UTC
Attachment 235863 [details] pushed as 605b918 - a11y: Drop obsolete focus tab handling in notebooks
Comment 4 Joanmarie Diggs (IRC: joanie) 2013-10-06 15:50:30 UTC
Matthias, I'm really sorry I'd spaced this one out. I suppose you knew that seeing it committed would remind me. ;)

Having said that, I just tried Gtk+ master and am still seeing the focus claims reported in the opening report using the associated test case. I'm guessing I'm doing something silly, but I'm not sure what. When I run the Application class demo, the About dialog says "3.11.0, Running against GTK+ 3.11.0." So as a quick sanity check, could you please confirm that you are not seeing the page-tab focus claims from the test case I provided.