After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693561 - window list should focus on drag and drop
window list should focus on drag and drop
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
classic
Depends on:
Blocks:
 
 
Reported: 2013-02-11 01:11 UTC by Benedikt Morbach
Modified: 2013-04-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window-list: Activate window on hover during drag operations (3.83 KB, patch)
2013-04-04 15:36 UTC, Florian Müllner
reviewed Details | Review
window-list: Set metaWindow for single-window items when grouped (1.51 KB, patch)
2013-04-04 15:36 UTC, Florian Müllner
committed Details | Review
window-list: Activate window on hover during drag operations (3.87 KB, patch)
2013-04-04 16:04 UTC, Florian Müllner
committed Details | Review

Description Benedikt Morbach 2013-02-11 01:11:27 UTC
the 'window list' extension should raise a window if you are hovering over the window name wile in drag&drop.
That way you can e.g. drag a picture from your fullscreen web browser into your office suite, without having to resize a window, Alt+Tab or going via Activities. 

Old gnome panel, other operating systems and other window list/panel type extensions do that.
I know a few users who rely heavily on this, so it would be great to get it in for 3.8
Comment 1 Florian Müllner 2013-04-04 15:36:50 UTC
Created attachment 240627 [details] [review]
window-list: Activate window on hover during drag operations

Reimplement the common task list behavior of activating windows
when hovering over a task list item during a drag operation.
Comment 2 Florian Müllner 2013-04-04 15:36:56 UTC
Created attachment 240628 [details] [review]
window-list: Set metaWindow for single-window items when grouped

When grouping is enabled, items that are only have a single window
associated are still expected to behave like ungrouped items.
This includes activating windows by DND, which uses the metaWindow
property on the hovered actor's _delegate, so make sure it is set
on AppButtons in single-window mode as well.
Comment 3 drago01 2013-04-04 15:55:49 UTC
Review of attachment 240627 [details] [review]:

::: extensions/window-list/extension.js
@@ +448,3 @@
+                                     Lang.bind(this, this._onDragEnd));
+        this._dragMonitor = {
+            dragMotion: Lang.bind(this, this._onDragMotion)

You probably want to remove the timeout here as well (user can cancel the drag during the timeout).
Comment 4 drago01 2013-04-04 15:56:49 UTC
Review of attachment 240628 [details] [review]:

Makes sense.
Comment 5 Florian Müllner 2013-04-04 16:04:28 UTC
Created attachment 240632 [details] [review]
window-list: Activate window on hover during drag operations

(In reply to comment #3)
> You probably want to remove the timeout here as well (user can cancel the drag
> during the timeout).

Yes, makes sense. Thanks!
Comment 6 drago01 2013-04-04 16:08:49 UTC
Review of attachment 240632 [details] [review]:

Looks good.
Comment 7 Florian Müllner 2013-04-04 16:12:01 UTC
Attachment 240628 [details] pushed as a97d08a - window-list: Set metaWindow for single-window items when grouped
Attachment 240632 [details] pushed as 91aa1cf - window-list: Activate window on hover during drag operations