After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693497 - The spinner is too close to the border
The spinner is too close to the border
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.6.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 686781
 
 
Reported: 2013-02-09 21:11 UTC by Andreas Nilsson
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (34.85 KB, image/png)
2013-02-09 21:11 UTC, Andreas Nilsson 		  Details
mockup (36.31 KB, image/png)
2013-02-09 21:12 UTC, Andreas Nilsson 		  Details
Align the spinner (1.55 KB, patch)
2013-02-22 10:20 UTC, Alexander Larsson 		committed Details | Review

Description Andreas Nilsson 2013-02-09 21:11:08 UTC 
Created attachment 235601 [details]
screenshot

The spinner that shows up when you load a VM is very close to the border. It would be nice if it aligned with the graphics in the select button, to make it look more centered.
Comment 1 Andreas Nilsson 2013-02-09 21:12:11 UTC 
Created attachment 235602 [details]
mockup

Then it would look like this
Comment 2 Alexander Larsson 2013-02-22 10:20:11 UTC 
Created attachment 237160 [details] [review]
Align the spinner
Comment 3 Zeeshan Ali 2013-02-22 11:03:49 UTC 
Review of attachment 237160 [details] [review]:

::: src/topbar.vala
@@ +78,2 @@
         select_btn = toolbar.add_button ("object-select-symbolic", null, false) as Gtk.Button;
+        spinner_sizegroup.add_widget (select_btn);

Don't you want to add other buttons too?
Comment 4 Alexander Larsson 2013-02-22 11:42:34 UTC 
Review of attachment 237160 [details] [review]:

::: src/topbar.vala
@@ +78,2 @@
         select_btn = toolbar.add_button ("object-select-symbolic", null, false) as Gtk.Button;
+        spinner_sizegroup.add_widget (select_btn);

There is not really a need for that, i just picked the one in the same place where the spinner appears.

Theoretically we *could* add the other image based buttons (but not the "Done" one), but I don't quite see the need for it.
Comment 5 Zeeshan Ali 2013-02-22 11:46:24 UTC 
Review of attachment 237160 [details] [review]:

ACK then
Comment 6 Alexander Larsson 2013-02-22 12:06:21 UTC 
Attachment 237160 [details] pushed as 7e67be0 - Align the spinner