After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693398 - sound: 'sound' and 'user-accounts' are missing from bash completions
sound: 'sound' and 'user-accounts' are missing from bash completions
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-08 04:42 UTC by Jeremy Bicha
Modified: 2013-02-11 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sound: fix sound missing from bash completions (3.03 KB, patch)
2013-02-08 04:42 UTC, Jeremy Bicha 		none Details | Review
user-accounts: fix user-accounts missing from bash completions (3.90 KB, patch)
2013-02-08 04:57 UTC, Jeremy Bicha 		none Details | Review
sound: fix sound missing from bash completions (3.00 KB, patch)
2013-02-08 05:00 UTC, Jeremy Bicha 		none Details | Review
user-accounts: fix user-accounts missing from bash completions (3.97 KB, patch)
2013-02-08 05:05 UTC, Jeremy Bicha 		rejected Details | Review
sound: fix sound missing from bash completions (3.61 KB, patch)
2013-02-08 05:08 UTC, Jeremy Bicha 		rejected Details | Review

Description Jeremy Bicha 2013-02-08 04:42:25 UTC 
'sound' and 'user-accounts' are missing from the bash autocompletions
because shell/list-panel.sh doesn't look in a data directory for .desktop's
Comment 1 Jeremy Bicha 2013-02-08 04:42:27 UTC 
Created attachment 235480 [details] [review]
sound: fix sound missing from bash completions
Comment 2 Jeremy Bicha 2013-02-08 04:57:56 UTC 
Created attachment 235481 [details] [review]
user-accounts: fix user-accounts missing from bash completions
Comment 3 Jeremy Bicha 2013-02-08 05:00:44 UTC 
Created attachment 235482 [details] [review]
sound: fix sound missing from bash completions
Comment 4 Jeremy Bicha 2013-02-08 05:05:00 UTC 
Created attachment 235483 [details] [review]
user-accounts: fix user-accounts missing from bash completions
Comment 5 Jeremy Bicha 2013-02-08 05:08:29 UTC 
Created attachment 235484 [details] [review]
sound: fix sound missing from bash completions
Comment 6 Matthias Clasen 2013-02-09 17:19:40 UTC 
Review of attachment 235483 [details] [review]:

The patch doesn't seem to have anything to do with bash completions. Forgot to update the commit message ?
Comment 7 Jeremy Bicha 2013-02-09 20:44:46 UTC 
When shell/completions/gnome-control-center is generated from shell/gnome-control-center.in by shell/list-panel.sh, 'sound' and 'user-accounts' are missing from the command_list. These patches move things around to where list-panel.sh expects them to be.
Comment 8 Bastien Nocera 2013-02-11 08:38:45 UTC 
Comment on attachment 235483 [details] [review]
user-accounts: fix user-accounts missing from bash completions

It's much less work to add the one-line match to the shell script.
Comment 9 Bastien Nocera 2013-02-11 08:39:56 UTC 
commit d7dbcab34f6d822b8441e0dc55c221b8a7995a3a
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Feb 11 09:36:54 2013 +0100

    shell: Add sound and user-accounts to the completion
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693398