After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693322 - Don't use deprecated GLib threading API
Don't use deprecated GLib threading API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-07 12:28 UTC by Marc Leeman
Modified: 2013-02-11 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glib_compat_private: deprecated GStaticRecMutex (961 bytes, patch)
2013-02-07 12:29 UTC, Marc Leeman
rejected Details | Review
gstrsvgoverlay: deprecated GStaticMutex -> GMutex (1.46 KB, patch)
2013-02-07 12:29 UTC, Marc Leeman
committed Details | Review
gstchromahold: deprecated GStaticMutex -> GMutex (2.03 KB, patch)
2013-02-07 12:30 UTC, Marc Leeman
committed Details | Review
mxfdemux: deprecated GStaticRWLock -> GRWLock (13.71 KB, patch)
2013-02-07 12:30 UTC, Marc Leeman
committed Details | Review
fimc: deprecated pthread_mutex_t -> GMutex (1.39 KB, patch)
2013-02-07 12:30 UTC, Marc Leeman
rejected Details | Review

Description Marc Leeman 2013-02-07 12:28:35 UTC
several Mutex related fixes in GIT
Comment 1 Marc Leeman 2013-02-07 12:29:03 UTC
Created attachment 235384 [details] [review]
glib_compat_private: deprecated GStaticRecMutex
Comment 2 Marc Leeman 2013-02-07 12:29:30 UTC
Created attachment 235385 [details] [review]
gstrsvgoverlay: deprecated GStaticMutex -> GMutex
Comment 3 Marc Leeman 2013-02-07 12:30:00 UTC
Created attachment 235386 [details] [review]
gstchromahold: deprecated GStaticMutex -> GMutex
Comment 4 Marc Leeman 2013-02-07 12:30:14 UTC
Created attachment 235387 [details] [review]
mxfdemux: deprecated GStaticRWLock -> GRWLock
Comment 5 Marc Leeman 2013-02-07 12:30:29 UTC
Created attachment 235388 [details] [review]
fimc: deprecated pthread_mutex_t -> GMutex
Comment 6 Tim-Philipp Müller 2013-02-07 13:57:25 UTC
Comment on attachment 235388 [details] [review]
fimc: deprecated pthread_mutex_t -> GMutex

This is not how it's supposed to be used now. It should be:

static GMutex mutex;

or

GMutex mutex;

in structs, and then

g_mutex_{init,lock,unlock,clear}(&mutex);
Comment 7 Tim-Philipp Müller 2013-02-09 19:36:32 UTC
Comment on attachment 235388 [details] [review]
fimc: deprecated pthread_mutex_t -> GMutex

Fixed differently:


commit 8f93c2448edcfaf85aa0672c8d87655d9443d2ae
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Sat Feb 9 18:46:48 2013 +0000

    mfc: fix compilation with newer GLib versions
    
    that don't include pthread.h any more from public headers.
    We could just fix this by including pthread.h ourselves,
    but we may just as well use atomic ops for this and
    simplify the code a little.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693322
Comment 8 Tim-Philipp Müller 2013-02-09 19:44:03 UTC
Comment on attachment 235384 [details] [review]
glib_compat_private: deprecated GStaticRecMutex

Not sure this makes sense?

In any case, we can just remove it. It's only used in decklinksrc which hasn't been ported yet anyway (and swfdec which should be removed)
Comment 9 Tim-Philipp Müller 2013-02-11 12:04:16 UTC
This is mostly fixed now, there are a few more related patches coming.