After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693313 - Improve tooltip support
Improve tooltip support
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-02-07 11:34 UTC by Thomas Wood
Modified: 2013-02-12 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tooltip: set the transient parent window on tooltips (1.23 KB, patch)
2013-02-07 11:34 UTC, Thomas Wood
rejected Details | Review
wayland: set the transient-inactive flag on tooltip surfaces (1.51 KB, patch)
2013-02-07 11:34 UTC, Thomas Wood
committed Details | Review
tooltip: set the transient parent when using the wayland backend (1.44 KB, patch)
2013-02-11 09:57 UTC, Thomas Wood
committed Details | Review

Description Thomas Wood 2013-02-07 11:34:30 UTC
Improve the tooltip support by setting the transient parent window on tooltips (to allow them to be positioned) and setting the "transient inactive" flag (to prevent the tooltips from receiving focus).
Comment 1 Thomas Wood 2013-02-07 11:34:33 UTC
Created attachment 235376 [details] [review]
tooltip: set the transient parent window on tooltips

Set the transient parent window on tooltips so that they can be positioned
correctly when using the Wayland backend.
Comment 2 Thomas Wood 2013-02-07 11:34:36 UTC
Created attachment 235377 [details] [review]
wayland: set the transient-inactive flag on tooltip surfaces

This prevents the tooltip surfaces from taking the focus away from the
parent surface.
Comment 3 Rob Bradford 2013-02-07 12:58:13 UTC
Review of attachment 235377 [details] [review]:

LGTM.
Comment 4 Rob Bradford 2013-02-07 12:59:02 UTC
Review of attachment 235376 [details] [review]:

Is this fine for the other backends?
Comment 5 Thomas Wood 2013-02-08 16:29:45 UTC
(In reply to comment #4)
> Review of attachment 235376 [details] [review]:
> 
> Is this fine for the other backends?

I had a look at the Quartz backend and I think it would be OK, but it would need someone to test it. The win32 backend would also need testing.
Comment 6 Matthias Clasen 2013-02-08 18:15:57 UTC
based on irc feedback, it seems we need to use another api for this; doing it with transient-for will break things on osx, at least.
Comment 7 Matthias Clasen 2013-02-11 03:09:10 UTC
Review of attachment 235376 [details] [review]:

according to irc feedback, its not
Comment 8 Thomas Wood 2013-02-11 09:57:37 UTC
Created attachment 235687 [details] [review]
tooltip: set the transient parent when using the wayland backend

Since setting the transient parent may cause problems on other backends, this
patch limits the change to just the Wayland backend.
Comment 9 Rob Bradford 2013-02-11 12:43:54 UTC
Review of attachment 235687 [details] [review]:

Yes, well ... this is a kinda hack that tightly couples the GTK+ and GDK behaviour. However i've no other alternative :-) and this allows us to make progress.