After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693302 - decodebin: g_mutex_new is deprecated
decodebin: g_mutex_new is deprecated
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-07 09:50 UTC by Marc Leeman
Modified: 2013-02-07 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
forgotten patch (3.76 KB, patch)
2013-02-07 12:34 UTC, Marc Leeman 		rejected Details | Review

Description Marc Leeman 2013-02-07 09:50:31 UTC 
replace g_mutex_new with g_mutex_init and g_mutex_free with g_mutex_clear in gsturidecobin.c and gstdecodebin2.c
Comment 1 Tim-Philipp Müller 2013-02-07 12:08:34 UTC 
Don't suppose you had a patch for that already and just forgot to attach it?
Comment 2 Marc Leeman 2013-02-07 12:33:57 UTC 
ok

somehow it did not upload
sec
Comment 3 Marc Leeman 2013-02-07 12:34:27 UTC 
Created attachment 235389 [details] [review]
forgotten patch
Comment 4 Marc Leeman 2013-02-07 13:11:43 UTC 
I noticed that if I attach the patch while creating the bug, it never uploads :-( 

I have to add the patches in a second step. I'll remember it.
Comment 5 Tim-Philipp Müller 2013-02-07 13:53:20 UTC 
It would be nice if you could actually test the patch as well, because this one is completely broken and will crash pretty much immediately.

The mutexes also need to be changed to be embedded in the structure instead of just calling the new API on NULL pointers...


commit f704b3f9757d22fe2cd17d59cdefdfa2e5f06a84
Author: Marc Leeman <marc.leeman@gmail.com>
Date:   Thu Feb 7 10:49:33 2013 +0100

    decodebin: g_mutex_new -> g_mutex_init
    
    Don't use deprecated GLib API.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693302