After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693261 - Use g_warning instead of goa_warning
Use g_warning instead of goa_warning
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
3.7.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-06 14:00 UTC by Debarshi Ray
Modified: 2013-02-07 12:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
online-accounts: Use g_warning instead of goa_warning (3.58 KB, patch)
2013-02-06 14:01 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2013-02-06 14:00:04 UTC
goa_warning is meant for goa-daemon, and it does not really add any value in this case. Switching to g_warning lets us cut down on the number of symbols that are exported from libgoabackend.
Comment 1 Debarshi Ray 2013-02-06 14:01:23 UTC
Created attachment 235311 [details] [review]
online-accounts: Use g_warning instead of goa_warning
Comment 2 Matthias Clasen 2013-02-06 21:26:44 UTC
Review of attachment 235311 [details] [review]:

sure
Comment 3 Debarshi Ray 2013-02-07 12:00:44 UTC
Comment on attachment 235311 [details] [review]
online-accounts: Use g_warning instead of goa_warning

Thanks for the review.