GNOME Bugzilla – Bug 693007
only show the lock icon on the top bar if we are locked
Last modified: 2013-02-03 14:03:22 UTC
Some of the comments in Bastiens recent power post: http://www.hadess.net/2013/02/power-management-in-gnome-38.html discussed that there should be some differentiation on the screen shield based on whether we are locked or not. Two things that were mentioned: - Only show the padlock icon in the top right if the user has to unlock - Allow C-A-L to lock the screen when the shield is already down
What should we show instead of the padlock, if we're not locked? An open padlock? The regular chat status? Nothing at all?
I would say nothing
I remember Reda making a mockup of an alternative locking strategy where the lock icon was quite prominent at the center, see bug 688208 but that was involving two different screens. If the proposed notifications layout changes would be implemented (that's bug 691008), we might have enough space to add the lock icon at the center without much changing the overall design. That could clutter the shield a bit too much though.
Created attachment 235063 [details] [review] ScreenShield: separate notifications for active and locked Now that we have an explicit active-but-not-locked state, we should use different signals to notify changes. lock-status-changed is renamed to active-changed, and a new locked-changed is introduced.
Created attachment 235064 [details] [review] UserMenu: don't show a lock icon when we're not actually locked The screen shield can now be active (forcing the lock-screen session mode) without being locked.
*** Bug 693075 has been marked as a duplicate of this bug. ***
Review of attachment 235063 [details] [review]: This is a good cleanup anyway.
Review of attachment 235064 [details] [review]: OK.
Attachment 235063 [details] pushed as ae0accb - ScreenShield: separate notifications for active and locked Attachment 235064 [details] pushed as b3549f4 - UserMenu: don't show a lock icon when we're not actually locked