GNOME Bugzilla – Bug 692913
apps-menu: improve submenu navigation
Last modified: 2013-04-04 12:41:54 UTC
gtk menus employ a so-called keep-up triangle to keep submenus from changing underneath you if you mouse towards the submenu and stray from a straight horizontal line, leaving the item you were in. I think we need something like this to make the navigation feel comfortable.
Created attachment 235033 [details] [review] apps-menu: Improve submenu navigation
Nice work, but it feels a little bit laggy now if I move the mouse vertically over the categories - the selection only jumps after I'm about halfway over the next item. This is different from gtk menus, where it jumps right away.
Created attachment 238338 [details] [review] apps-menu: Improve submenu navigation Only use the keep-up triangle if the mouse movement is more horizontal than vertical.
hmm, with this patch, I don't seem to get any keepup - as soon as I leave the menuitem, the submenu changes. Even if I move in a largely horizontal direction.
Created attachment 239353 [details] [review] apps-menu: Improve submenu navigation In the previous patch, the keep-up triangle only worked if you threw the mouse over to the left instead of moving it slowly. This was caused by the fact that the following statement does not result in a copy-by-value: this._old_coords = coords; This patch addresses that issue.
Works great now in my testing
Ping. Would be nice to have it in 3.8.0.
Hey, can we get this merged for 3.8.1 ?
Review of attachment 239353 [details] [review]: Looks good, not sure the values 5 and 50 work in all cases but they did in my quick testing.
Comment on attachment 239353 [details] [review] apps-menu: Improve submenu navigation Thanks for the review. Pushed.