After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692693 - Disconnect content-updated signal early
Disconnect content-updated signal early
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-28 11:04 UTC by Giovanni Campagna
Modified: 2013-01-28 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disconnect content-updated signal early (2.43 KB, patch)
2013-01-28 11:04 UTC, Giovanni Campagna 		committed Details | Review
MessageTray: disconnect signal to notification early (1.94 KB, patch)
2013-01-28 11:10 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-01-28 11:04:20 UTC 
During the box pointer animation, other events can trigger an updateState,
losing the information that the summary is hiding and thus never disconnecting
the signals. Then, this stale connections can cause stacktraces, as they
fire when summaryBoxPointerItem is null.
Comment 1 Giovanni Campagna 2013-01-28 11:04:22 UTC 
Created attachment 234601 [details] [review]
Disconnect content-updated signal early
Comment 2 Giovanni Campagna 2013-01-28 11:10:35 UTC 
Created attachment 234603 [details] [review]
MessageTray: disconnect signal to notification early

Similar to the previous patch, this adds robustness and prevents more
stacktraces and confusion in the state machine.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-28 16:57:56 UTC 
Review of attachment 234601 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-01-28 16:58:09 UTC 
Review of attachment 234603 [details] [review]:

OK.
Comment 5 Giovanni Campagna 2013-01-28 19:37:38 UTC 
Please review bug 683986. The second patch here is on top of this one.
Comment 6 Giovanni Campagna 2013-01-28 20:04:10 UTC 
Attachment 234601 [details] pushed as cc60afa - Disconnect content-updated signal early
Attachment 234603 [details] pushed as 4545719 - MessageTray: disconnect signal to notification early