After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692564 - handle load failure gracefully
handle load failure gracefully
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-25 22:33 UTC by William Jon McCann
Modified: 2013-01-29 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (32.35 KB, image/png)
2013-01-25 22:33 UTC, William Jon McCann 		  Details
Use a better fail whale (902 bytes, patch)
2013-01-29 09:36 UTC, William Jon McCann 		committed Details | Review
Use proper quotes (2.04 KB, patch)
2013-01-29 09:36 UTC, William Jon McCann 		committed Details | Review
Make sure toolbar is shown on load error (1.71 KB, patch)
2013-01-29 09:36 UTC, William Jon McCann 		reviewed Details | Review
Simplify load error message (824 bytes, patch)
2013-01-29 09:36 UTC, William Jon McCann 		committed Details | Review
Humanize libgdata error messages (2.06 KB, patch)
2013-01-29 09:36 UTC, William Jon McCann 		reviewed Details | Review
Make sure toolbar is shown on load error (2.39 KB, patch)
2013-01-29 16:03 UTC, William Jon McCann 		committed Details | Review
Humanize libgdata error messages (2.08 KB, patch)
2013-01-29 16:04 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-01-25 22:33:31 UTC 
Created attachment 234450 [details]
screenshot

We should handle load failure gracefully.
Comment 1 William Jon McCann 2013-01-29 09:36:21 UTC 
Created attachment 234704 [details] [review]
Use a better fail whale
Comment 2 William Jon McCann 2013-01-29 09:36:24 UTC 
Created attachment 234705 [details] [review]
Use proper quotes
Comment 3 William Jon McCann 2013-01-29 09:36:27 UTC 
Created attachment 234706 [details] [review]
Make sure toolbar is shown on load error
Comment 4 William Jon McCann 2013-01-29 09:36:30 UTC 
Created attachment 234707 [details] [review]
Simplify load error message
Comment 5 William Jon McCann 2013-01-29 09:36:32 UTC 
Created attachment 234708 [details] [review]
Humanize libgdata error messages
Comment 6 Cosimo Cecchi 2013-01-29 11:18:29 UTC 
Review of attachment 234704 [details] [review]:

++
Comment 7 Cosimo Cecchi 2013-01-29 11:19:01 UTC 
Review of attachment 234705 [details] [review]:

++
Comment 8 Cosimo Cecchi 2013-01-29 11:23:21 UTC 
Review of attachment 234706 [details] [review]:

::: src/preview.js
@@ +220,3 @@
                 this._fsToolbar.show();
+            if (this._model)
+                this._navBar.show();

Can you do the document_model != null check in PreviewNav itself?
Comment 9 Cosimo Cecchi 2013-01-29 11:24:14 UTC 
Review of attachment 234707 [details] [review]:

++
Comment 10 Cosimo Cecchi 2013-01-29 11:27:13 UTC 
Review of attachment 234708 [details] [review]:

::: src/documents.js
@@ +940,3 @@
+            }
+        }
+            case GData.ServiceError.AUTHENTICATION_REQUIRED:

AFAICS we don't only get GData errors here; in case the domain is not GData.ServiceError, shouldn't we still use a descripton? 'message' is left undefined in that case by this function.
Comment 11 William Jon McCann 2013-01-29 16:03:37 UTC 
Created attachment 234759 [details] [review]
Make sure toolbar is shown on load error
Comment 12 William Jon McCann 2013-01-29 16:04:27 UTC 
Created attachment 234760 [details] [review]
Humanize libgdata error messages
Comment 13 Cosimo Cecchi 2013-01-29 16:12:55 UTC 
Review of attachment 234760 [details] [review]:

Yes
Comment 14 Cosimo Cecchi 2013-01-29 16:17:25 UTC 
Review of attachment 234759 [details] [review]:

Yes
Comment 15 William Jon McCann 2013-01-29 18:13:46 UTC 
Attachment 234704 [details] pushed as a80d0ee - Use a better fail whale
Attachment 234705 [details] pushed as 9ed2378 - Use proper quotes
Attachment 234707 [details] pushed as 1aa07f9 - Simplify load error message
Attachment 234759 [details] pushed as 203c1e4 - Make sure toolbar is shown on load error
Attachment 234760 [details] pushed as dcdedd8 - Humanize libgdata error messages
Comment 16 William Jon McCann 2013-01-29 18:33:05 UTC 
Attachment 234705 [details] pushed as 9ed2378 - Use proper quotes
Attachment 234707 [details] pushed as 1aa07f9 - Simplify load error message
Attachment 234759 [details] pushed as 203c1e4 - Make sure toolbar is shown on load error
Attachment 234760 [details] pushed as dcdedd8 - Humanize libgdata error messages
Comment 17 William Jon McCann 2013-01-29 18:35:56 UTC 
Attachment 234705 [details] pushed as 9ed2378 - Use proper quotes
Attachment 234707 [details] pushed as 1aa07f9 - Simplify load error message
Attachment 234759 [details] pushed as 203c1e4 - Make sure toolbar is shown on load error