After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692530 - Position of thumbnail in properties in wrong place in fullscreen
Position of thumbnail in properties in wrong place in fullscreen
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 686781
 
 
Reported: 2013-01-25 14:18 UTC by Alexander Larsson
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix positioning of thumbnail in properties view (1.79 KB, patch)
2013-01-28 14:22 UTC, Alexander Larsson 		reviewed Details | Review
Fix positioning of thumbnail in properties view (1.24 KB, patch)
2013-02-06 09:30 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2013-01-25 14:18:21 UTC 
If you go to the properties view when a VM is in fullscreen mode the thumbnail seems to be off in the y direction by the height of the toolbar.
Comment 1 Alexander Larsson 2013-01-28 14:22:07 UTC 
Created attachment 234619 [details] [review]
Fix positioning of thumbnail in properties view

When going to the properties view from fullscreen we were showing
the thumbnail in the wrong place, as the size used was the gtk
position when the fullscreen topbar was visible. We had a workaround
for this already, it just needs to be moved to sync with other changes
that had been done in this area.
Comment 2 Zeeshan Ali 2013-01-28 19:27:08 UTC 
Review of attachment 234619 [details] [review]:

::: src/machine.vala
@@ +777,3 @@
 
+            // Temporarily hide toolbar in fullscreen so that the the animation
+            // actor doesn't get pushed down before zooming to the sidebar

with this being done also when not zooming, the comment doesn't make sense to me. Also how does this change fix anything cause 'zoom' is true when in fullscreen.
Comment 3 Alexander Larsson 2013-02-06 09:30:11 UTC 
Created attachment 235293 [details] [review]
Fix positioning of thumbnail in properties view

We had some leftover code that used to fix an issue with this, but
its just not needed anymore and actually causes a problem. Just
removing this code fixes the positioning of the thumbnail.
Comment 4 Alexander Larsson 2013-02-06 09:30:55 UTC 
Not only is the commend bad, the whole thing is not needed...
Comment 5 Zeeshan Ali 2013-02-06 12:57:47 UTC 
Review of attachment 235293 [details] [review]:

ack
Comment 6 Alexander Larsson 2013-02-07 09:11:15 UTC 
Attachment 235293 [details] pushed as 33883de - Fix positioning of thumbnail in properties view