Created attachment 234379 [details] [review]
manager: Add InhibitedFor D-Bus property

This makes it easier for system-level applications to check
whether a particular action is inhibited without calling
"IsInhibited" for each action separately.

Review of attachment 234379 [details] [review]:

::: gnome-session/gsm-manager.c
@@ +2652,3 @@
+        /**
+         * GsmManager::inhibited-for
+         *

I think you need a trailing : here to make gtk-doc happy. But then, gtk-doc never comes here anyway...

I could bikeshed on the name; 'for' in a property name like that doesn't look great to me. Maybe 'inhibited-actions' ?

Created attachment 234388 [details] [review]
manager: Add InhibitedActions D-Bus property

This makes it easier for system-level applications to check
whether a particular action is inhibited without calling
"IsInhibited" for each action separately.

(In reply to comment #2)
> Review of attachment 234379 [details] [review]:
> 
> ::: gnome-session/gsm-manager.c
> @@ +2652,3 @@
> +        /**
> +         * GsmManager::inhibited-for
> +         *
> 
> I think you need a trailing : here to make gtk-doc happy. But then, gtk-doc
> never comes here anyway...

It's consistent with the other comments above properties in this code.

> I could bikeshed on the name; 'for' in a property name like that doesn't look
> great to me. Maybe 'inhibited-actions' ?

Done.

Created attachment 234392 [details] [review]
manager: Add InhibitedActions D-Bus property

This makes it easier for system-level applications to check
whether a particular action is inhibited without calling
"IsInhibited" for each action separately.

Attachment 234392 [details] pushed as a0057de - manager: Add InhibitedActions D-Bus property