After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692332 - GNetworkMonitorNetlink: make the netlink socket cloexec
GNetworkMonitorNetlink: make the netlink socket cloexec
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-01-22 21:55 UTC by Dan Winship
Modified: 2013-01-23 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GNetworkMonitorNetlink: make the netlink socket cloexec (4.57 KB, patch)
2013-01-22 21:55 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2013-01-22 21:55:08 UTC 
Noticed while playing with bug 672102 comment 129

Alternative naming suggestions for g_socket() accepted.
Comment 1 Dan Winship 2013-01-22 21:55:10 UTC 
Created attachment 234145 [details] [review]
GNetworkMonitorNetlink: make the netlink socket cloexec

Use the same code GSocket does, to try SOCK_CLOEXEC first, and then
fall back to FD_CLOEXEC if it fails. (And fix that code to not call
fcntl if SOCK_CLOEXEC worked.)
Comment 2 Matthias Clasen 2013-01-23 02:13:25 UTC 
Review of attachment 234145 [details] [review]:

Looks fine to me
Comment 3 Dan Winship 2013-01-23 13:49:30 UTC 
Attachment 234145 [details] pushed as 5932e16 - GNetworkMonitorNetlink: make the netlink socket cloexec