GNOME Bugzilla – Bug 692249
Add Help button & rename `Cancel' to `Close' in Custom Reports dialog box
Last modified: 2018-06-29 23:13:02 UTC
A `Help' button in the Custom Reports dialog box would be able to open the newly-added after bug #633590) custom reports documentation. Also, I want to rename the `Cancel' button to `Close' because this isn't a modal dialog. After a little rearranging, the final dialog could look like: |===============================| | Custom Reports x| |-------------------------------| |---------- -------| || Delete | | Run || |---------- -------| |-------------------------------| | Report1 | | Report2 | | ... | |-------------------------------| |-------- ---------| || Help | | Close || |-------- ---------| ================================= Roughly speaking.
Hi Yawar, I'm fine with renaming the Cancel button to 'Close', but I don't like the layout where there's a button in every corner of the window. The way I see it this goes against consistent user interface design. If you only envision minimal change to the dialog, you should add the Help button below and keep the run button where it is. But if you are interested in a more thought out redesign, let me add some thoughts: We can look at this window in two ways: - either we consider this window as a (modeless) dialog. Common to dialogs is that all the action buttons are at the bottom. That means that at least the run button belongs there as well. And if the run button moves down, I don't see any point in keeping the delete button up there alone, so to keep things simple, it should go below as well. I can also imagine a slight variation of this dialog idea, which I would like even more, though it's not completely consistent with traditional UX. Go with three buttons below: help, close, run. This is how a typical dialog is laid out. For the delete option: put an icon representing an X at the end of each report line, with a tooltip "Delete". Clicking that icon will ask for confirmation to delete the given report and do so if confirmed. - or we could also see the Custom Reports dialog as an independent window, something of a simplified file manager. In that case, it would make sense to work with a toolbar with the 4 actions you present: Run, Delete, Close, Help. And while we're talking about a redesign for the Custom Reports dialog window, let me add another missing feature: an option to rename a report. This could be done both in the dialog concept or in the window concept. In the independent window concept it can easily be implemented by adding another toolbar button. For the dialog concept, let's extend on the simplified file manager idea: we could add another mini button on each line, say with the symbol of a pencil. Either way (toolbar or directly in line),clicking the edit name button will make the title of the report editable. Once the name has changed, the code behind the scenes should do whatever necessary to rename the report.
Created attachment 276324 [details] [review] Add help button The issues with the layout and rename of cancel to close that are mentioned in this bug have been resolved one way or another. The only thing remaining to close the bug is the addition of the help button in the dialog, which is handled by this patch.
Comment on attachment 276324 [details] [review] Add help button A wonderful small detail cleanup. Applied to the maintenance branch and merged into master. Thank you very much !
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=692249. Please update any external references or bookmarks.