After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692220 - sharing: fix the sensitivity of the "share with trusted devices" switch
sharing: fix the sensitivity of the "share with trusted devices" switch
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-21 17:18 UTC by Thomas Wood
Modified: 2013-01-23 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sharing: fix the sensitivity of the "share with trusted devices" switch (5.65 KB, patch)
2013-01-21 17:18 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2013-01-21 17:18:02 UTC 
Allow the GSettings binding to set the sensitivity of the switch and use a box
to allow the sharing panel to set the sensitivity of the switch and label
without conflicting with the GSettings binding.
Comment 1 Thomas Wood 2013-01-21 17:18:07 UTC 
Created attachment 234032 [details] [review]
sharing: fix the sensitivity of the "share with trusted devices" switch

Allow the GSettings binding to set the sensitivity of the switch and use a
box to allow the sharing panel to set the sensitivity of the switch and
label without conflicting with the GSettings binding.
Comment 2 Bastien Nocera 2013-01-23 11:17:22 UTC 
Review of attachment 234032 [details] [review]:

Fine, though not very elegant.
Comment 3 Thomas Wood 2013-01-23 14:02:06 UTC 
It's actually more consistent with the rest of the code this way, where a "master" switch controls the sensitivity of multiple other controls, of which there may be more than one level of these relationships.
Comment 4 Thomas Wood 2013-01-23 16:13:33 UTC 
Rebased patch pushed as commit d29d752.