After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692171 - power: Impossible to scroll power panel up/down using only keyboard
power: Impossible to scroll power panel up/down using only keyboard
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
git master
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-21 08:32 UTC by Jeremy Bicha
Modified: 2013-01-28 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Improve keyboard navigation (5.96 KB, patch)
2013-01-22 11:18 UTC, Matthias Clasen
needs-work Details | Review
power: Improve keyboard navigation (5.91 KB, patch)
2013-01-23 03:17 UTC, Matthias Clasen
none Details | Review
power: Improve keyboard navigation (6.03 KB, patch)
2013-01-28 09:50 UTC, Bastien Nocera
committed Details | Review

Description Jeremy Bicha 2013-01-21 08:32:34 UTC
gnome-control-center from jhbuild on Ubuntu 13.04 Alpha

1. Open Settings to the Power panel.
2. Use the keyboard (tab and arrow keys) to navigate and select different elements
3. Select something that is "off the page" (not visible without scrolling, like the bottom item in the list)

What should happen
The view should be automatically scrolled down so that the selected item is visible.

In fact, it looks like it's currently not possible to scroll the page down using just the keyboard (arrow keys, tab, and even Page Up/Page Down).
Comment 1 Matthias Clasen 2013-01-22 11:18:23 UTC
Created attachment 234095 [details] [review]
power: Improve keyboard navigation

This commit 'links' the arrow navigation between the list boxes
in the power page, so that it becomes possible to arrow down all
the way from the battery section to automatic suspend. We also
set up the focus adjustment so that the focus row gets scrolled
into view.

This requires the egg-list-box module to have
commit 98b0a39efe7b1892570ece53748ab153a91b9cbc.
Comment 2 Jeremy Bicha 2013-01-22 14:44:47 UTC
Review of attachment 234095 [details] [review]:

It looks like your branch is a week out of date as this doesn't apply cleanly against trunk.
Comment 3 Matthias Clasen 2013-01-23 02:31:28 UTC
Yeah, it was accidentally written against a different branch. I'll provide a new one.
Comment 4 Matthias Clasen 2013-01-23 03:17:18 UTC
Created attachment 234161 [details] [review]
power: Improve keyboard navigation

This commit 'links' the arrow navigation between the list boxes
in the power page, so that it becomes possible to arrow down all
the way from the battery section to automatic suspend. We also
set up the focus adjustment so that the focus row gets scrolled
into view.

This requires the egg-list-box module to have
commit 98b0a39efe7b1892570ece53748ab153a91b9cbc.
Comment 5 Jeremy Bicha 2013-01-23 04:50:38 UTC
Thanks, the arrow keys work how I expect with your patch.

Page Up/Page Down however does not; it only scrolls up or down one item (like the arrow keys) instead of up or down by ~ a page. Do you want me to open a new bug for that?
Comment 6 Matthias Clasen 2013-01-23 23:48:55 UTC
The behaviour of page up/down in egglistbox is an egglistbox issue.
I'm not sure if you'll get what you want here though; the best we can do with the current setup is to have page down go from the first item to the last, then to the first item of the next list, then to the last item, and so on.
Comment 7 Bastien Nocera 2013-01-28 09:50:37 UTC
Created attachment 234597 [details] [review]
power: Improve keyboard navigation

This commit 'links' the arrow navigation between the list boxes
in the power page, so that it becomes possible to arrow down all
the way from the battery section to automatic suspend. We also
set up the focus adjustment so that the focus row gets scrolled
into view.

This requires the egg-list-box module to have
commit 98b0a39efe7b1892570ece53748ab153a91b9cbc.
Comment 8 Bastien Nocera 2013-01-28 09:52:02 UTC
Not shorter, but more elegant I think.
Comment 9 Bastien Nocera 2013-01-28 10:02:26 UTC
Attachment 234597 [details] pushed as cf7530b - power: Improve keyboard navigation