After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692026 - Never ending redirects in WebKitGtk
Never ending redirects in WebKitGtk
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.41.x
Other Linux
: Normal major
: ---
Assigned To: Sergio Villar
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-18 18:13 UTC by Sergio Villar
Modified: 2013-01-18 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.09 KB, patch)
2013-01-18 18:18 UTC, Sergio Villar
accepted-commit_now Details | Review

Description Sergio Villar 2013-01-18 18:13:25 UTC
Redirects (3xx messages) are not completely processed when using epiphany with the latest WebKitGtk+. It's easy to see this behaviour with the web inspector loading things like http://www.ohloh.net.
Comment 1 Sergio Villar 2013-01-18 18:18:19 UTC
Created attachment 233780 [details] [review]
Patch

The problem was that priv->eof was not updated correctly on _skip() (which is used right now in WebKitGtk+ for redirect messages). So, we WebKitGtk+ was trying to close the stream, soup_body_input_stream_create_source() was creating a pollable source (that will never issue anything) instead a plain g_timeout_source(0) to close the stream immediately.
Comment 2 Dan Winship 2013-01-18 18:28:18 UTC
Comment on attachment 233780 [details] [review]
Patch

oh, I saw this but it went away with the patch in https://bugs.webkit.org/show_bug.cgi?id=106789 (wihch makes it not use skip), so I assumed it was just part of the thread-based flakiness
Comment 3 Sergio Villar 2013-01-18 18:36:34 UTC
Commited 1d94ff