After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691991 - Add support for building ATK with Visual Studio 2012
Add support for building ATK with Visual Studio 2012
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
git master
Other Windows
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-18 03:44 UTC by Fan, Chun-wei
Modified: 2014-04-25 00:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for VS 2012 builds with autotools scripts (3.78 KB, patch)
2013-01-18 03:44 UTC, Fan, Chun-wei
none Details | Review
Add support for VS 2012 builds with autotools scripts (take ii) (3.35 KB, patch)
2014-04-24 11:49 UTC, Fan, Chun-wei
committed Details | Review

Description Fan, Chun-wei 2013-01-18 03:44:01 UTC
Created attachment 233713 [details] [review]
Add support for VS 2012 builds with autotools scripts

Hi,

I have came up with an autotools script to automate the "upgrade" of Visual Studio 2010 project files to Visual Studio 2012 during "make dist" so that we can also provide support for building ATK with Visual Studio 2012, in addition to the currently-supported Visual Studio 2008/2010.

The rational behind this script is that the VS 2012 project files are only slightly different from their VS 2010 counterparts, so we only need a simple script to copy the VS 2010 projects and then replacing the necessary parts to create project files that can be used by VS 2012.

Thank you, with blessings!
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-04-23 15:39:13 UTC
I missed this bug, but Visual Studio files changed a lot since then. Is this bug still valid?
Comment 2 Fan, Chun-wei 2014-04-24 11:49:46 UTC
Created attachment 275049 [details] [review]
Add support for VS 2012 builds with autotools scripts (take ii)

Hi Piñeiro,

Indeed this patch set needed some updates, although not that big.  So, here's the revised patch.  I think it shouldn't be too hard to add Visual Studio 2013 support to it, but that's what I have for it for now.

p.s. I do think it's a good idea to add Visual Studio 2013 project file support via a method like this, for the next stable release of the GTK+/Clutter stack, especially as builds of Clutter were fixed for Visual Studio 2012 and later.

With blessings, thank you!
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-04-24 13:53:43 UTC
Review of attachment 275049 [details] [review]:

Although Im not able to test it on visual studio, it looks good in genera, and I rely on your experience.
Comment 4 Fan, Chun-wei 2014-04-25 00:35:06 UTC
Review of attachment 275049 [details] [review]:

Hi Piñeiro,

I have committed the patch as 84da842f, thanks for the reviews.

Will close this bug in a bit.

With blessings, thank you!