After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691979 - Changes to allow for a "No results found" widget
Changes to allow for a "No results found" widget
Status: RESOLVED FIXED
Product: egg-list-box
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: egg-list-box-maint
egg-list-box-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-17 21:32 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-15 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
egg-list-box: Fix indentation (1.42 KB, patch)
2013-01-17 21:32 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
egg-list-box: Move refiltered behavior to be a signal (3.24 KB, patch)
2013-01-17 21:32 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
egg-list-box: Remove redundant check (915 bytes, patch)
2013-01-17 21:33 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
egg-list-box: Don't allow selection/activation of insensitive widgets (2.22 KB, patch)
2013-01-17 21:33 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-17 21:32:54 UTC 
We want to add an insensitive "No results found" label when we're
filtering. I thought about adding an "empty" prop that returns whether
there are visible children, but showing a label based on that would
make state tracking very iffy.

This was the best way I could think to accomplish it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-17 21:32:56 UTC 
Created attachment 233698 [details] [review]
egg-list-box: Fix indentation
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-17 21:32:58 UTC 
Created attachment 233699 [details] [review]
egg-list-box: Move refiltered behavior to be a signal

If we want to show a widget when there are no children left after
a refilter, we need a hook to be able to calculate that. Adding
a signal allows us to run handlers before and after the refiltering
is done.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-17 21:33:03 UTC 
Created attachment 233700 [details] [review]
egg-list-box: Remove redundant check

A ChildInfo's widget should never be NULL.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-01-17 21:33:06 UTC 
Created attachment 233701 [details] [review]
egg-list-box: Don't allow selection/activation of insensitive widgets
Comment 5 Matthias Clasen 2013-01-17 23:15:17 UTC 
Review of attachment 233698 [details] [review]:

sure
Comment 6 Matthias Clasen 2013-01-17 23:22:09 UTC 
Review of attachment 233699 [details] [review]:

Makes sense to me
Comment 7 Matthias Clasen 2013-01-17 23:22:53 UTC 
Review of attachment 233700 [details] [review]:

sure
Comment 8 Matthias Clasen 2013-01-17 23:25:12 UTC 
Review of attachment 233701 [details] [review]:

I think we eventually need more control over activation/selection - it should be possible to have a row that is sensitive, yet not activatable.
Comment 9 Matthias Clasen 2013-01-18 00:04:27 UTC 
Review of attachment 233699 [details] [review]:

If we had any docs here, it would be good to explain the 'no matches' use case with an example.
Given that we don't have docs yet, good as is
Comment 10 Matthias Clasen 2013-01-18 00:04:37 UTC 
Review of attachment 233699 [details] [review]:

If we had any docs here, it would be good to explain the 'no matches' use case with an example.
Given that we don't have docs yet, good as is
Comment 11 Matthias Clasen 2013-01-18 00:06:03 UTC 
Review of attachment 233701 [details] [review]:

I think if we do this, we also have to watch for sensitivity changes of children, or we may end up in confused state...
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-01-18 00:07:59 UTC 
Attachment 233698 [details] pushed as a2b8fcd - egg-list-box: Fix indentation
Attachment 233699 [details] pushed as f72c0e7 - egg-list-box: Move refiltered behavior to be a signal
Attachment 233700 [details] pushed as f6ed227 - egg-list-box: Remove redundant check
Comment 13 Jasper St. Pierre (not reading bugmail) 2013-02-15 00:13:06 UTC 
Selection of insensitive widgets will have to be done a different way. Let's close this.