After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691965 - power: Fix blanking not working
power: Fix blanking not working
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on: 691964
Blocks:
 
 
Reported: 2013-01-17 17:57 UTC by Bastien Nocera
Modified: 2013-01-22 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Fix blanking not working (4.90 KB, patch)
2013-01-17 17:57 UTC, Bastien Nocera
none Details | Review
power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed) (2.83 KB, patch)
2013-01-17 18:14 UTC, Bastien Nocera
none Details | Review
power: Fix blanking not working (4.94 KB, patch)
2013-01-17 19:29 UTC, Bastien Nocera
none Details | Review
power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed) (2.82 KB, patch)
2013-01-21 15:43 UTC, Bastien Nocera
none Details | Review
power: Fix blanking not working (2.78 KB, patch)
2013-01-21 20:08 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-01-17 17:57:16 UTC
.
Comment 1 Bastien Nocera 2013-01-17 17:57:18 UTC
Created attachment 233680 [details] [review]
power: Fix blanking not working

When we got the ActiveChanged() signal from gnome-shell's screen lock,
we would reconfigure the blank time out to be much shorter. The problem
is that the timeout is based on idleness, and we would already have been
past that amount of idleness when we setup the new idle monitor.

Instead of basing ourselves on idle timeouts, just wait for the
screensaver to come on. Once it comes on, we'll do the initial blanking
after the expected fade timeout, and handle idleness as expected (so
it's possible to cancel the login, and have the screen be blanked
quickly).
Comment 2 Bastien Nocera 2013-01-17 18:14:21 UTC
Created attachment 233681 [details] [review]
power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed)

When we got the ActiveChanged() signal from gnome-shell's screen lock,
we would reconfigure the blank time out to be much shorter. The problem
is that the timeout is based on idleness, and we would already have been
past that amount of idleness when we setup the new idle monitor.

Instead of basing ourselves on idle timeouts, just wait for the
screensaver to come on and blank it. We'll handle idleness as normal
(so it's possible to cancel the login, and have the screen be blanked
quickly).
Comment 3 Bastien Nocera 2013-01-17 19:29:02 UTC
Created attachment 233694 [details] [review]
power: Fix blanking not working

When we got the ActiveChanged() signal from gnome-shell's screen lock,
we would reconfigure the blank time out to be much shorter. The problem
is that the timeout is based on idleness, and we would already have been
past that amount of idleness when we setup the new idle monitor.

Instead of basing ourselves on idle timeouts, just wait for the
screensaver to come on. Once it comes on, we'll do the initial blanking
after the expected fade timeout, and handle idleness as expected (so
it's possible to cancel the login, and have the screen be blanked
quickly).
Comment 4 Bastien Nocera 2013-01-17 19:29:57 UTC
Comment on attachment 233680 [details] [review]
power: Fix blanking not working

Was missing the "if (active)" line.
Comment 5 Bastien Nocera 2013-01-21 15:43:23 UTC
Created attachment 234016 [details] [review]
power: Fix blanking not working (if gnome-shell's ActiveChanged gets fixed)

When we got the ActiveChanged() signal from gnome-shell's screen lock,
we would reconfigure the blank time out to be much shorter. The problem
is that the timeout is based on idleness, and we would already have been
past that amount of idleness when we setup the new idle monitor.

Instead of basing ourselves on idle timeouts, just wait for the
screensaver to come on and blank it. We'll handle idleness as normal
(so it's possible to cancel the login, and have the screen be blanked
quickly).
Comment 6 Bastien Nocera 2013-01-21 20:08:31 UTC
Created attachment 234045 [details] [review]
power: Fix blanking not working

When we got the ActiveChanged() signal from gnome-shell's screen lock,
we would reconfigure the blank time out to be much shorter. The problem
is that the timeout is based on idleness, and we would already have been
past that amount of idleness when we setup the new idle monitor.

Instead of basing ourselves on idle timeouts, just wait for the
screensaver to come on and blank it. We'll handle idleness as normal
(so it's possible to cancel the login, and have the screen be blanked
quickly).
Comment 7 Bastien Nocera 2013-01-22 08:23:41 UTC
I've pushed this as carrying this patch when running test cases is getting
to be too much of a trouble. We'll *need* to have gnome-shell fixed before the 3.7.5 release.

Attachment 234045 [details] pushed as e0e50ea - power: Fix blanking not working