GNOME Bugzilla – Bug 691935
[x264] Should detect bit depth and color formats at runtime
Last modified: 2013-02-08 00:17:03 UTC
See summary, instead of using the #defines from x264_config.h it should use x264_bit_depth and x264_chroma_format at runtime.
Created attachment 234173 [details] [review] x264enc: detect supported bit depth and pixel formats at runtime Like this? Or should we advertise all theoretically supported formats in the template and then restrict via query_caps at run time? And why is this a 'major' bug?
Comment on attachment 234173 [details] [review] x264enc: detect supported bit depth and pixel formats at runtime Yes, thanks :) It was major because Debian now has a library for 8 bit and another one for 10 bit in their package and you can switch between both at runtime.
Decided to put all formats for the given arch in the temple caps now: commit 201e3f74be99915582418d2ec27b7069805fb01d Author: Tim-Philipp Müller <tim@centricular.net> Date: Fri Feb 8 00:11:03 2013 +0000 x264enc: put all theoretically possible formats in template caps and decide at runtime which subset of these (8-bit or 10-bit video formats) is supported. libx264 will be compiled for one of these two options, and it is possible to switch by pointing the dynamic linker to a different libx264 build at runtime. If we want our template caps to be correct, they should contain all then, with the actually supported ones determined at runtime. https://bugzilla.gnome.org/show_bug.cgi?id=691935 commit e765deb01b781354cac2cbaf930cbea5e7d9d9f1 Author: Tim-Philipp Müller <tim@centricular.net> Date: Wed Jan 23 10:16:51 2013 +0000 x264enc: detect supported bit depth and pixel formats at runtime http://bugs.debian.org/667573 https://bugzilla.gnome.org/show_bug.cgi?id=691935