After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691672 - evince-3.6.1 segfaults when dbus isn't running
evince-3.6.1 segfaults when dbus isn't running
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 700572 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-13 19:50 UTC by Brennan Shacklett
Modified: 2013-05-19 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix segfault and allow files to still be opened without running dbus (1.16 KB, patch)
2013-01-13 19:56 UTC, Brennan Shacklett
committed Details | Review

Description Brennan Shacklett 2013-01-13 19:50:59 UTC
If evince is built with ./configure --enable-dbus, when the binary is run on a machine without dbus running, evince will segfault when launched without a file, and will simply exit when evince is run with a file as an argument.

I was referred here from this gentoo bug: https://bugs.gentoo.org/show_bug.cgi?id=451578 , where it was determined that the best solution is to fix the segfault.
Comment 1 Brennan Shacklett 2013-01-13 19:56:04 UTC
Created attachment 233399 [details] [review]
Patch to fix segfault and allow files to still be opened without running dbus

This is a patch against evince-3.6.1 because I don't have a new enough version of gtk+ on my machine to build the trunk version of evince to test the patch; however, the patch does apply cleanly against the trunk.

The patch checks for a null pointer in the code that was causing the segfault and instead of just returning from the dbus enabled open uri code falls back to the function that opens documents with dbus support when the program doesn't have a connection to dbus.
Comment 2 Carlos Garcia Campos 2013-02-02 14:56:41 UTC
Comment on attachment 233399 [details] [review]
Patch to fix segfault and allow files to still be opened without running dbus

Pushed to git master, thank you very much
Comment 3 Christian Persch 2013-05-19 11:41:22 UTC
*** Bug 700572 has been marked as a duplicate of this bug. ***