GNOME Bugzilla – Bug 691613
Don't use glxinfo to access the graphic driver name
Last modified: 2013-04-13 06:36:51 UTC
glxinfo is part of mesa-demos, and installing it pulls a lot of unnecessary programs. We can get the same informations by querying the driver directly.
Created attachment 233308 [details] [review] Don't use glxinfo to access the graphic driver name
Review of attachment 233308 [details] [review]: Why would we not want to use GLX? This shouldn't be a configure option IMO. Does it play nicely with clutter? (as used in the user-accounts panel when cheese support is enabled)
(In reply to comment #2) > Review of attachment 233308 [details] [review]: > > Why would we not want to use GLX? This shouldn't be a configure option IMO. Because you may want EGL? Think of wayland. (Of course, that means that we should have a GLX implementation and a EGL implementation...) > Does it play nicely with clutter? (as used in the user-accounts panel when > cheese support is enabled) I believe so, yes. I explicitly use a different GLX context and a dummy X window, so there should be no conflict.
(In reply to comment #3) > (In reply to comment #2) > > Review of attachment 233308 [details] [review] [details]: > > > > Why would we not want to use GLX? This shouldn't be a configure option IMO. > > Because you may want EGL? Think of wayland. Let's think of wayland when we do start porting to Wayland. For now, I don't see a point in doing so (gnome-settings-daemon is a hard-dep of gnome-control-center, and can only compile against X11, to start with...). > (Of course, that means that we should have a GLX implementation and a EGL > implementation...) > > > Does it play nicely with clutter? (as used in the user-accounts panel when > > cheese support is enabled) > > I believe so, yes. I explicitly use a different GLX context and a dummy X > window, so there should be no conflict. Great. Can you respin the patch without the compile-time option?
doesn't linking against gl incur a rather heavy startup time penalty ?
(In reply to comment #5) > doesn't linking against gl incur a rather heavy startup time penalty ? Would that startup penalty be any different from the one we already incur through clutter usage?
Created attachment 233471 [details] [review] Don't use glxinfo to access the graphic driver name glxinfo is part of mesa-demos, and installing it pulls a lot of unnecessary programs. We can get the same informations by querying the driver directly.
Review of attachment 233471 [details] [review]: Looks good.
Attachment 233471 [details] pushed as c60221e - Don't use glxinfo to access the graphic driver name
*** Bug 690527 has been marked as a duplicate of this bug. ***
shouldn't the configure check as well for "x11" since the code is using XCreateSimpleWindow()? (I tried to backport that patch on 3.6 and ran into a build issue due to that, will try on 3.8 next)
This fails on nvidia blob. Seems that glXCreateWindow () is throwing a BadMatch Error.
Created attachment 241310 [details] [review] Fix display of graphic driver name. Use XCreateWindow to ensure we are using the same X VisualInfo on both the config and window. This avoids a BadMatch error on nvidia glx implementation. XCreateSimpleWindow appears to make a copy of the X Visual that has a different visualID. This mismatch in VisualID's is what was throwing the BadMatch error.
Comment on attachment 241310 [details] [review] Fix display of graphic driver name. Filed as a new bug here -> https://bugzilla.gnome.org/show_bug.cgi?id=697881