Bug 691142 – goa-daemon appears to leak timerfds

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 691142 - goa-daemon appears to leak timerfds


Summary:	goa-daemon appears to leak timerfds


Status:	RESOLVED FIXED

Product:	gnome-online-accounts
Classification:	Core
Component:	Kerberos
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Online Accounts maintainer(s)
QA Contact:	GNOME Online Accounts maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Attachments
identity: Don't try to sign in with a NULL identity (979 bytes, patch) 2013-01-08 16:28 UTC, Debarshi Ray	committed	Details \| Review
identity: Don't leak the GoaKerberosIdentity (1.41 KB, patch) 2013-01-08 16:29 UTC, Debarshi Ray	committed	Details \| Review

Description Matthias Clasen 2013-01-04 18:10:04 UTC

look at https://bugzilla.redhat.com/show_bug.cgi?id=875621
in particular https://bugzilla.redhat.com/attachment.cgi?id=643307

Comment 1 Debarshi Ray 2013-01-08 16:28:30 UTC

Created attachment 232982 [details] [review]
identity: Don't try to sign in with a NULL identity

Comment 2 Debarshi Ray 2013-01-08 16:29:41 UTC

Created attachment 232983 [details] [review]
identity: Don't leak the GoaKerberosIdentity

Comment 3 Ray Strode [halfline] 2013-01-08 16:30:38 UTC

Review of attachment 232982 [details] [review]:

++

Comment 4 Ray Strode [halfline] 2013-01-08 16:32:50 UTC

Review of attachment 232983 [details] [review]:

Thanks!

Comment 5 Debarshi Ray 2013-01-08 16:36:21 UTC

Thanks for the quick review.