After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691130 - egg-list-box: make egg_list_box_set_sort_func() usable from gjs
egg-list-box: make egg_list_box_set_sort_func() usable from gjs
Status: RESOLVED FIXED
Product: egg-list-box
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: egg-list-box-maint
egg-list-box-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-04 13:13 UTC by Carl-Anton Ingmarsson
Modified: 2013-04-09 07:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
egg-list-box: make egg_list_box_set_sort_func() usable from gjs (2.48 KB, patch)
2013-01-04 13:13 UTC, Carl-Anton Ingmarsson 		reviewed Details | Review
Patch with warning (2.61 KB, patch)
2013-04-08 22:28 UTC, Carl-Anton Ingmarsson 		accepted-commit_now Details | Review

Description Carl-Anton Ingmarsson 2013-01-04 13:13:16 UTC 
See attached patch.
Comment 1 Carl-Anton Ingmarsson 2013-01-04 13:13:18 UTC 
Created attachment 232730 [details] [review]
egg-list-box: make egg_list_box_set_sort_func() usable from gjs

Use a function signature with explicit pointer types and annotate egg_list_box_set_sort_func
properly.
Comment 2 Allan Day 2013-02-08 09:54:43 UTC 
GNOME Clocks may well need this.
Comment 3 Matthias Clasen 2013-02-08 14:51:03 UTC 
Review of attachment 232730 [details] [review]:

Looks good to me; it might cause some compiler warnings in modules that are passing GCompareDataFuncs currently, so a warning in the commit message might be nice.
Comment 4 Carl-Anton Ingmarsson 2013-04-08 22:28:38 UTC 
Created attachment 240984 [details] [review]
Patch with warning
Comment 5 Matthias Clasen 2013-04-09 01:14:20 UTC 
Review of attachment 240984 [details] [review]:

Looks good to me.
Comment 6 Matthias Clasen 2013-04-09 01:14:30 UTC 
Review of attachment 240984 [details] [review]:

Looks good to me.