After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691016 - Gio: Don't eat errors when calling reply functions
Gio: Don't eat errors when calling reply functions
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-02 14:56 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-02 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Gio: Don't eat errors when calling reply functions (1.29 KB, patch)
2013-01-02 14:56 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-02 14:56:34 UTC
I finally found why I wasn't getting any error logging!

I wish JS had Python's try...else. Maybe Harmony will save us,
eventually.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-02 14:56:36 UTC
Created attachment 232529 [details] [review]
Gio: Don't eat errors when calling reply functions

If somebody errors out during a DBus reply callback, we should
let them know about it, rather than keep them guessing.
Comment 2 Giovanni Campagna 2013-01-02 17:02:46 UTC
Review of attachment 232529 [details] [review]:

Ugh.
Yes, definitely.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-02 17:04:31 UTC
Attachment 232529 [details] pushed as f8878e6 - Gio: Don't eat errors when calling reply functions