After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690994 - videodecoder: Allow parse function to not use all data on the adapter
videodecoder: Allow parse function to not use all data on the adapter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-02 11:18 UTC by Thijs Vermeir
Modified: 2013-02-12 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-videodecoder-allow-parse-function-to-not-use-all-dat.patch (3.72 KB, patch)
2013-01-02 11:19 UTC, Thijs Vermeir 		committed Details | Review

Description Thijs Vermeir 2013-01-02 11:18:33 UTC 
When the decoder is accepting non-packetized data, it currently needs to consume all data in the parse function. This is not useful/optimal if the parse function is looking for packets over the border of different incoming buffers.

I propose to also allow exiting the parse loop if the parse function did not consume any data from the adapter.
Comment 1 Thijs Vermeir 2013-01-02 11:19:22 UTC 
Created attachment 232509 [details] [review]
0001-videodecoder-allow-parse-function-to-not-use-all-dat.patch
Comment 2 Sebastian Dröge (slomo) 2013-02-12 09:18:40 UTC 
commit d189beda4d130515d88920de4f1d240c3aca0435
Author: Thijs Vermeir <thijsvermeir@gmail.com>
Date:   Wed Jan 2 12:15:25 2013 +0100

    videodecoder: allow parse function to not use all data on adapter