After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690897 - Esc does not close the chat notification bubbles
Esc does not close the chat notification bubbles
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-30 17:24 UTC by Olivier Crête
Modified: 2013-01-02 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grabHelper: Allow pressing escape on grab focus grabs (3.02 KB, patch)
2013-01-02 10:56 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
grabHelper: Allow pressing escape on grab focus grabs (3.02 KB, patch)
2013-01-02 13:11 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Olivier Crête 2012-12-30 17:24:40 UTC 
If I look in the tray and select a conversation, then Esc closes it. But if it's an "incoming" notification, I can't close it with the Escape key.. This should be made consistent.

Using gnome-shell-3.6.2-3.fc18
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-02 10:56:27 UTC 
Created attachment 232508 [details] [review]
grabHelper: Allow pressing escape on grab focus grabs

We didn't install the captured event handler on grab focus grabs,
leading to the case where we didn't ungrab correctly.


--

Patch untested, because gnome-online-accounts and empathy conspired
me from actually connecting to chat.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-02 13:11:07 UTC 
Created attachment 232520 [details] [review]
grabHelper: Allow pressing escape on grab focus grabs

We didn't install the captured event handler on grab focus grabs,
leading to the case where we didn't ungrab correctly.



Fixes a stuck grab issue, and a modal grab issue due to typos.

Still not tested with focus grabs, will try to get g-o-a working today.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-02 17:33:38 UTC 
Attachment 232520 [details] pushed as 52ca15b - grabHelper: Allow pressing escape on grab focus grabs