After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690895 - Fix keyring breakages
Fix keyring breakages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-30 17:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-30 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyring: Fix copy/paste error (990 bytes, patch)
2012-12-30 17:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
keyring: Actually ensure sensitivity when the keyring dialog opens (1.48 KB, patch)
2012-12-30 17:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-30 17:06:15 UTC 
I should have tested the patches before. My fault; sorry.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-30 17:06:16 UTC 
Created attachment 232397 [details] [review]
keyring: Fix copy/paste error

This was clearly meant to be continueButton.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-30 17:06:19 UTC 
Created attachment 232398 [details] [review]
keyring: Actually ensure sensitivity when the keyring dialog opens

I misunderstood how the control flow for the keyring worked.
Comment 3 Cosimo Cecchi 2012-12-30 17:56:07 UTC 
Review of attachment 232397 [details] [review]:

Looks good to me.
Comment 4 Cosimo Cecchi 2012-12-30 17:56:24 UTC 
Review of attachment 232398 [details] [review]:

Looks good to me.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-30 19:10:00 UTC 
Attachment 232397 [details] pushed as 3e6b794 - keyring: Fix copy/paste error
Attachment 232398 [details] pushed as 75d44dc - keyring: Actually ensure sensitivity when the keyring dialog opens