Created attachment 232338 [details] [review]
Remove builtin settings search provider

It is now provided as a remote provider by gnome-control-center.

Cosimo wasn't sure this was the greatest idea, but I forget his rationale.

Do we expect settings to be fixed, or should users be able to disable the provider or reorder it? In the former case, leaving it in the shell is probably cleaner than special-casing it in g-c-c; otherwise I can't think of a reason not to do this ...

I can think of restricted user modes where settings as a whole are hidden from the user - so allowing a system administrator to disable the g-c-c search provider would make sense.

Created attachment 236614 [details] [review]
Remove builtin settings search provider

It is now provided as a remote provider by gnome-control-center.

For now, we decided that gnome-control-center is special cased and not configurable.

*** Bug 691779 has been marked as a duplicate of this bug. ***

Review of attachment 236614 [details] [review]:

::: js/ui/remoteSearch.js
@@ +126,3 @@
+
+    // Special case gnome-control-center to be always active and always first
+    sortOrder.unshift('gnome-control-center.desktop');

Hmm, gnome-control-center.desktop should never be in GSettings, as it's not user-visible. You should sort the loadState.loadedProviders list normally and then put the control center one at the top.

(In reply to comment #8)
> Review of attachment 236614 [details] [review]:
> 
> ::: js/ui/remoteSearch.js
> @@ +126,3 @@
> +
> +    // Special case gnome-control-center to be always active and always first
> +    sortOrder.unshift('gnome-control-center.desktop');
> 
> Hmm, gnome-control-center.desktop should never be in GSettings, as it's not
> user-visible. You should sort the loadState.loadedProviders list normally and
> then put the control center one at the top.

Indeed, this works because gnome-control-center is not in GSettings: unshift adds the control-center provider at the front of the sort order, so the later call to sort() ensures that the provider object is first.

Review of attachment 236614 [details] [review]:

Completely misread the patch, sorry.

Attachment 236614 [details] pushed as 3044a6b - Remove builtin settings search provider