After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690751 - Outdated example in docs/manual/advanced-metadata.xml
Outdated example in docs/manual/advanced-metadata.xml
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-26 23:07 UTC by Gert Kulyk
Modified: 2013-02-13 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the tags.c example (1.23 KB, patch)
2012-12-26 23:07 UTC, Gert Kulyk
needs-work Details | Review

Description Gert Kulyk 2012-12-26 23:07:30 UTC
Created attachment 232252 [details] [review]
Patch to fix the tags.c example

The tags.c example in docs/manual/advanced-metadata.xml does no longer compile with released versions of gstreamer1.0. I'm attaching a patch to fix this.
Comment 1 Tim-Philipp Müller 2012-12-26 23:20:57 UTC
Comment on attachment 232252 [details] [review]
Patch to fix the tags.c example

Thanks for the patch! You have no idea how rare it is that we get patches for documentation :)

However, I think it would be better  to replace DATE with DATE_TIME and GDate API with GstDateTime API.

If there are still GDates floating about in tags, those need to be fixed to GstDateTimes really (a GstDateTime is a GDate plus time fields, where unlike with GDate some fields can be optional).
Comment 2 Tim-Philipp Müller 2013-02-13 21:39:12 UTC
Updated and pushed to master, thanks for the patch!



commit 21c4c718b243a52cce0f99424a9ca22a8ae709eb
Author: Gert Michael Kulyk <gkulyk@yahoo.de>
Date:   Thu Dec 27 00:03:06 2012 +0100

    docs: fix advanced-metadata code example in manual
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690751