After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690726 - lookingGlass: Move to an inspect() function
lookingGlass: Move to an inspect() function
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-26 03:37 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-28 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lookingGlass: Move to an inspect() function (2.06 KB, patch)
2012-12-26 03:37 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-26 03:37:51 UTC
A friend I was showing the looking glass to tried to enter
"<inspect x:10, y:20>" into the evaluator, as that's what we
put in there when you use the eyedropper.

Add a function to quickly pick an actor at some coordinates,
and fake the syntax instead of using invalid syntax.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-26 03:37:54 UTC
Created attachment 232226 [details] [review]
lookingGlass: Move to an inspect() function

Rather than add invalid results to the place where you enter JavaScript
commands when you use the eyedropped, add an inspect() function and add
a fake call to it.
Comment 2 Giovanni Campagna 2012-12-26 18:17:43 UTC
Review of attachment 232226 [details] [review]:

LGTM
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-28 08:21:08 UTC
Attachment 232226 [details] pushed as fa1420b - lookingGlass: Move to an inspect() function