After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690667 - Patches for jhbuild wrapper / test runner
Patches for jhbuild wrapper / test runner
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-23 09:20 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-24 02:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
run-test: Load shell files from the srcdir (1.04 KB, patch)
2012-12-23 09:20 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
run-js-test: initialize shell introspection (1.32 KB, patch)
2012-12-23 09:20 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
gnome-shell-jhbuild: Remove old envvar (1.17 KB, patch)
2012-12-23 09:20 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-23 09:20:29 UTC 
See patches. None of these are necessary; they're just convenient.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-23 09:20:32 UTC 
Created attachment 232145 [details] [review]
run-test: Load shell files from the srcdir
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-23 09:20:35 UTC 
Created attachment 232146 [details] [review]
run-js-test: initialize shell introspection
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-23 09:20:38 UTC 
Created attachment 232147 [details] [review]
gnome-shell-jhbuild: Remove old envvar

This isn't used anymore.
Comment 4 Giovanni Campagna 2012-12-23 12:38:59 UTC 
Review of attachment 232145 [details] [review]:

This one is surely needed, you don't want to test the installed shell instead of the built one...
Comment 5 Giovanni Campagna 2012-12-23 12:40:53 UTC 
Review of attachment 232146 [details] [review]:

::: src/run-js-test.c
@@ +65,3 @@
+
+  g_irepository_prepend_search_path (MUTTER_TYPELIB_DIR);
+  g_irepository_prepend_search_path (GNOME_SHELL_PKGLIBDIR);

This one will cause run-js-test to pick the installed Shell-0.1 and St-1.0 instead of the just built one. It looks wrong to me.
Comment 6 Giovanni Campagna 2012-12-23 12:41:14 UTC 
Review of attachment 232147 [details] [review]:

Yes
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-12-24 02:18:29 UTC 
Attachment 232145 [details] pushed as 86a8452 - run-test: Load shell files from the srcdir
Attachment 232147 [details] pushed as ab638a4 - gnome-shell-jhbuild: Remove old envvar


OK, didn't push.