After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690627 - blue toolbar for selection mode
blue toolbar for selection mode
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-21 21:09 UTC by William Jon McCann
Modified: 2013-01-08 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a blue selection bar (4.22 KB, patch)
2012-12-21 21:13 UTC, William Jon McCann
needs-work Details | Review
Use a blue selection bar (15.03 KB, patch)
2013-01-07 20:34 UTC, William Jon McCann
committed Details | Review

Comment 1 William Jon McCann 2012-12-21 21:13:01 UTC
Created attachment 232094 [details] [review]
Use a blue selection bar
Comment 2 Cosimo Cecchi 2012-12-22 10:32:39 UTC
Review of attachment 232094 [details] [review]:

gtk-main.css is not ususally changed without a corresponding change for the dark theme (and gtk-main-common.css is shared between the two).
This needs to be fixed before we push it, since the selection mode toolbar is used by Boxes and Photos.

::: themes/Adwaita/gtk-3.0/gtk-main-common.css
@@ -72,3 @@
-
-@define-color selection_toolbar_suggested_button_fg #ffffff;
-@define-color selection_toolbar_suggested_button_a #7fc141;

This seems to be removed but another shadow color is not added?

::: themes/Adwaita/gtk-3.0/gtk-main.css
@@ +137,3 @@
+
+@define-color selection_toolbar_bg_a #97b9db;
+@define-color selection_toolbar_suggested_button_fg #ffffff;

We still have @selection_toolbar_bg too...once you also address the dark theme coverage, that probably would need to be renamed or changed altogether.
Comment 3 William Jon McCann 2013-01-04 20:40:01 UTC
Guys, what should the dark theme look like?
Comment 4 Jakub Steiner 2013-01-07 07:45:07 UTC
Slightly darkened selection toolbar for the dark theme -- https://raw.github.com/gnome-design-team/gnome-mockups/master/boxes/boxes-selection.png
Comment 5 William Jon McCann 2013-01-07 20:34:03 UTC
Created attachment 232934 [details] [review]
Use a blue selection bar
Comment 6 Cosimo Cecchi 2013-01-08 22:59:54 UTC
Attachment 232934 [details] pushed as 372c27f - Use a blue selection bar

Pushed this to master after some tweaks, thanks!