GNOME Bugzilla – Bug 690627
blue toolbar for selection mode
Last modified: 2013-01-08 22:59:57 UTC
https://github.com/gnome-design-team/gnome-mockups/blob/master/documents/next-selection-toolbar.png
Created attachment 232094 [details] [review] Use a blue selection bar
Review of attachment 232094 [details] [review]: gtk-main.css is not ususally changed without a corresponding change for the dark theme (and gtk-main-common.css is shared between the two). This needs to be fixed before we push it, since the selection mode toolbar is used by Boxes and Photos. ::: themes/Adwaita/gtk-3.0/gtk-main-common.css @@ -72,3 @@ - -@define-color selection_toolbar_suggested_button_fg #ffffff; -@define-color selection_toolbar_suggested_button_a #7fc141; This seems to be removed but another shadow color is not added? ::: themes/Adwaita/gtk-3.0/gtk-main.css @@ +137,3 @@ + +@define-color selection_toolbar_bg_a #97b9db; +@define-color selection_toolbar_suggested_button_fg #ffffff; We still have @selection_toolbar_bg too...once you also address the dark theme coverage, that probably would need to be renamed or changed altogether.
Guys, what should the dark theme look like?
Slightly darkened selection toolbar for the dark theme -- https://raw.github.com/gnome-design-team/gnome-mockups/master/boxes/boxes-selection.png
Created attachment 232934 [details] [review] Use a blue selection bar
Attachment 232934 [details] pushed as 372c27f - Use a blue selection bar Pushed this to master after some tweaks, thanks!