Created attachment 232078 [details] [review]
h323-endpoint: remove gatekeeperID variable

The gatkeeperID is not assigned, so no information is passed to it,
hence it is better to use the default parameter value (Empty), and the
code is more clean.

Created attachment 232079 [details] [review]
h323-endpoint: remove unused code

This code is not used at all. Even more it is commented out, and it
makes reference to aor (address of register) which only makes sense in
SIP.

Created attachment 232080 [details] [review]
h323-endpoint: add the username in authentication

Not only the password should be used for the gatekeeper
authentication, but the username too.

Created attachment 232081 [details] [review]
h323-endpoint: remove unused variable

The unregistered variable is only used once and it is more clear to
use account.is_enabled () accessor.

Created attachment 232082 [details] [review]
h323-endpoint: use the gatekeeper accessor

Instead of using the internal attribute gatkeeper, it is more clean to
use th available accessor for it.

Created attachment 232083 [details] [review]
h323-endpoint: assign gk_name only if success

Only if the method H323EndPoint::UseGatekeeper() is successfull, the address
of the gatekeeper will be assigned to the gk_name flag attribute

Created attachment 232084 [details] [review]
h323-endpoint: unregister the gatekeeper for real

When one unregister the h323 account it doesn't happen anything, and
when registering again, the message "processing" never changes. This
patch fixes this bug. Now the unregistering happens for real and the
re-registering is more clean.

Review of attachment 232078 [details] [review]:

Good.

Review of attachment 232079 [details] [review]:

Good.

Review of attachment 232080 [details] [review]:

Good.

Review of attachment 232081 [details] [review]:

Good.

Review of attachment 232081 [details] [review]:

Good.

Review of attachment 232082 [details] [review]:

Good.

Review of attachment 232083 [details] [review]:

Good.

Review of attachment 232084 [details] [review]:

Good.

Thank you very much!  All of them have been committed unchanged (except some logs).