After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690427 - Handle 'switch-input-source' keybinding move
Handle 'switch-input-source' keybinding move
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 690426
Blocks:
 
 
Reported: 2012-12-18 16:13 UTC by Rui Matos
Modified: 2012-12-18 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle 'switch-input-source' keybinding move (3.88 KB, patch)
2012-12-18 16:13 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-12-18 16:13:11 UTC 
Patch attached.
Comment 1 Rui Matos 2012-12-18 16:13:14 UTC 
Created attachment 231815 [details] [review]
Handle 'switch-input-source' keybinding move

Moving this to gsettings-desktop-schemas instead so that
gnome-control-center doesn't have to grow a dependency on gnome-shell.
Comment 2 Florian Müllner 2012-12-18 16:39:07 UTC 
Review of attachment 231815 [details] [review]:

Currently all g-c-c keybinding files for WM related shortcuts are installed by either mutter or gnome-shell, so I wouldn't remove it (that way the shortcut doesn't show up in Settings when running an unsupported WM), but I don't care deeply - up to you really.
Comment 3 Rui Matos 2012-12-18 17:05:09 UTC 
(In reply to comment #2)
> Currently all g-c-c keybinding files for WM related shortcuts are installed by
> either mutter or gnome-shell, so I wouldn't remove it (that way the shortcut
> doesn't show up in Settings when running an unsupported WM), but I don't care
> deeply - up to you really.

I understand, but in this case g-c-c also displays the keybindings in
the region panel accessing the schema directly and it also already
provided the .xml file for the Typing shortcuts section so I opted to
just update it there.

Attachment 231815 [details] pushed as 07511cb - Handle 'switch-input-source' keybinding move