After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690422 - Add smartcard support
Add smartcard support
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-18 15:44 UTC by Alexander Larsson
Modified: 2016-03-31 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add smartcard support (6.18 KB, patch)
2012-12-18 15:44 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2012-12-18 15:44:25 UTC 
If --enable-smartcard support is passed we create new VMs with
smartcard support, or let you add it to old VMs.

This requires the new libvirt-glib smartcard support
Comment 1 Alexander Larsson 2012-12-18 15:44:27 UTC 
Created attachment 231812 [details] [review]
Add smartcard support
Comment 2 Zeeshan Ali 2012-12-18 17:32:43 UTC 
Review of attachment 231812 [details] [review]:

Looks good otherwise. I assume you tested this change. I don't have a smartcard so can't test. :(

::: configure.ac
@@ +49,3 @@
 GTK_VNC_MIN_VERSION=0.4.4
+LIBVIRT_GLIB_MIN_VERSION=0.1.5
+LIBVIRT_GCONFIG_MIN_VERSION=0.1.5

Lets put that in a separate commit, please. Just makes it easy to not miss dep changes while writing release notes.

::: src/libvirt-machine.vala
@@ +554,3 @@
                 var inactive_config = domain.get_config (GVir.DomainXMLFlags.INACTIVE);
                 foreach (var device in inactive_config.get_devices ()) {
+                    print ("%s\n", Type.from_instance (device).name());

Don't forget to remove this. :)

@@ +586,3 @@
             }
 
+            /* Only add usb support to guests if HAVE_SMARTCARD, as qemu built

coding-style nitpick: Use //
Comment 3 Alexander Larsson 2012-12-19 13:04:52 UTC 
Attachment 231812 [details] pushed as 39b39e6 - Add smartcard support