After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690421 - Jobs dialog - use an attached toolbar
Jobs dialog - use an attached toolbar
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-18 15:39 UTC by Allan Day
Modified: 2013-01-16 11:45 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
screenshot of jobs dialog (27.15 KB, image/png)
2013-01-15 14:54 UTC, Marek Kašík 		  Details
Attach toolbar controlling jobs to list of jobs (2.93 KB, patch)
2013-01-15 15:19 UTC, Marek Kašík 		committed Details | Review

Description Allan Day 2012-12-18 15:39:20 UTC 
The printer jobs dialog has three buttons at the bottom. These should be contained within a toolbar that is attached to the bottom of the jobs list. This style of attached toolbar can be seen in many parts of system settings, including the printer panel itself.
Comment 1 Marek Kašík 2013-01-15 14:54:23 UTC 
Created attachment 233528 [details]
screenshot of jobs dialog

Hi,

you are right, it is better this way. Do you want to have the buttons grouped (see the screenshot) or separated?

Marek
Comment 2 Allan Day 2013-01-15 15:04:43 UTC 
Hey Marek, this looks nicer indeed. :)

Grouped looks good to me.
Comment 3 Marek Kašík 2013-01-15 15:19:02 UTC 
Created attachment 233531 [details] [review]
Attach toolbar controlling jobs to list of jobs
Comment 4 Marek Kašík 2013-01-15 15:20:51 UTC 
(In reply to comment #3)
> Created an attachment (id=233531) [details] [review]
> Attach toolbar controlling jobs to list of jobs

This patch implements the proposed change.
Comment 5 Bastien Nocera 2013-01-16 11:35:26 UTC 
Review of attachment 233531 [details] [review]:

++
Comment 6 Marek Kašík 2013-01-16 11:44:53 UTC 
Comment on attachment 233531 [details] [review]
Attach toolbar controlling jobs to list of jobs

Thanks for the review and the report. I've committed the patch to master.