After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690395 - Structural navigation objects should be navigable by a "list of" dialog
Structural navigation objects should be navigable by a "list of" dialog
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.31.x
Other All
: Normal enhancement
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
: 620331 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-12-18 06:53 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2013-02-11 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Joanmarie Diggs (IRC: joanie) 2012-12-18 06:53:58 UTC
Structural navigation objects should be navigable by a "list of" dialog.
Comment 1 Joanmarie Diggs (IRC: joanie) 2012-12-18 06:59:37 UTC
*** Bug 620331 has been marked as a duplicate of this bug. ***
Comment 2 Joanmarie Diggs (IRC: joanie) 2012-12-18 07:04:04 UTC
Here's the method to get the objects via the collection interface.
http://git.gnome.org/browse/orca/commit/?id=741c55fceae7f4b2bd2c026d1a7f42b6a9f8271b

Here's the generic gui which can be used to display a list of, as well as handle navigation to and activation of, accesssibles:
http://git.gnome.org/browse/orca/commit/?id=132537f2784dabac4e1a39e7a7af3087007cf898

I still need to do the object-specific population and keybindings. (And, yes, I will do this. No patches are needed. Thanks.)
Comment 3 Hammer Attila 2012-12-18 07:25:18 UTC
Joanie, only the activate button label need marking translation the src/orca/orca_gui_navlist.py file ? Some places the code use the title parameter, but the dialog title what form are presenting?

Not need setting future the treeview what column are searchable (set_search_column method)?

I would like thank you the implementation related doing works.

Attila
Comment 4 Joanmarie Diggs (IRC: joanie) 2012-12-18 07:32:59 UTC
Attila, when things need to be marked for translation, I will mark them for translation and mark them in the appropriate place. Please allow me to finish this.
Comment 5 Joanmarie Diggs (IRC: joanie) 2013-02-04 02:11:17 UTC
This adds the support needed to:
* look for and populate keybindings
* show the dialog with the data provided

http://git.gnome.org/browse/orca/commit/?id=1ba0a00374063c65f0424bf6dc2b66832c4090c2

No, it's not everything that needs to be done, but it's close. Yes, I am still working on it. And, yes, I plan for it to be done in time for Orca 3.8.
Comment 6 Joanmarie Diggs (IRC: joanie) 2013-02-05 05:48:19 UTC
This adds the dialog data methods. (It looks long, but it's about 85% translator notes and 15% code.)

http://git.gnome.org/browse/orca/commit/?id=8237c6039ac101a23432a08db9cf9d8dac3848ed
Comment 7 Joanmarie Diggs (IRC: joanie) 2013-02-05 06:22:47 UTC
This adds the bindings:
http://git.gnome.org/browse/orca/commit/?id=81a71240065e8db8a7ee647ae21f8f1931a9a715

I still have nits and known issues to fix -- which I will detail on the mailing list next and keep working on. But as of now the testable version is live. May the Fates take pity on us all. <grins>
Comment 8 Hammer Attila 2013-02-05 07:25:19 UTC
Million thanks Joanie, I will be try the new function. Now I finished the hungarian translation the new messages my local system. :-):-)

Attila
Comment 9 Joanmarie Diggs (IRC: joanie) 2013-02-05 07:52:26 UTC
(In reply to comment #8)
> Million thanks Joanie, I will be try the new function. Now I finished the
> hungarian translation the new messages my local system. :-):-)

Thanks! That's one of the reasons I wanted to get what I had committed. There's a healthy number of new strings.

I just sent a detailed explanation to the Orca list. Please give that a read and let's try to have the community discussion there. Let's keep this bug under 100 comments. <grins>
Comment 10 Joanmarie Diggs (IRC: joanie) 2013-02-07 22:20:57 UTC
Tackling some of the remaining nits....

This commit causes us to present the number of results found: In the title bar when there are results; as a message when there are not:
http://git.gnome.org/browse/orca/commit/?id=cdcc81731b710cdab2ce8a3dd42612698c1e1295

This commit causes us to indicate when columns and rows have been resorted. It's not specific to this feature here at all. But it does apply to this feature:
http://git.gnome.org/browse/orca/commit/?id=9f4337b994361688fe1d07b668521db91f738b67

This commit causes us to select the row associated with the current item *when there is an exact match*. I explained this on the Orca list in more detail.
http://git.gnome.org/browse/orca/commit/?id=cf222c4dd9fbb005eeadfbee5eef3e4b31836988

And since no one has yet protested the binding switch, this commit unbinds some hardly-used bindings so that we can "steal" Alt+Shift as the default modifier for the dialogs:
http://git.gnome.org/browse/orca/commit/?id=c65200edf508e32331badcb20694ecfb6e962636
Comment 12 Joanmarie Diggs (IRC: joanie) 2013-02-11 17:10:31 UTC
Of the remaining structural navigation elements, my conclusions are as follows:

Anchors and separators - What is of interest is not the object itself, but the surrounding objects. That makes them poor candidates for list-of dialogs.

Table cells in a data table make sense only in the context of the table in which they are present. This makes them poor candidates for list-of dialogs. Table cells in layout tables should show up in the large object list-of dialogs.

Thus the only elements left to do are landmarks and live regions. The live region code doesn't seem especially reliable independent of the dialog feature; and I would like to find more landmarks in the wild before I dialogize them. So I will tackle those later and as separate bugs/features.

Having done everything on my to-do list, I am closing this bug as FIXED. Questions/comments/feedback should be sent to the Orca list rather than added here. Bug reports should be filed as new bugs.