After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690344 - App menu shouldn't include VM specific items
App menu shouldn't include VM specific items
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 686781
 
 
Reported: 2012-12-17 13:25 UTC by Bastien Nocera
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Remove 'fullscreen' & 'properties' from global menu (2.22 KB, patch)
2013-01-08 01:40 UTC, Zeeshan Ali 		needs-work Details | Review
app: Remove 'fullscreen' & 'properties' from global menu (2.63 KB, patch)
2013-01-11 15:13 UTC, Zeeshan Ali 		committed Details | Review

Description Bastien Nocera 2012-12-17 13:25:54 UTC 
Properties and Force Shutdown are VM specific shortcuts (maybe even Fullscreen, as it's only available when something is playing).

Those should instead be in a menu button in the toolbar (in fact, fullscreen and properties are already are).
Comment 1 Zeeshan Ali 2012-12-17 14:25:33 UTC 
" Force Shutdown" is already removed in 3.7.x. IIRC Marc-Andre was against removing "Force Shutdown" so I'd like to hear what he has to say on this.
Comment 2 Marc-Andre Lureau 2012-12-17 16:36:31 UTC 
(In reply to comment #1)
> " Force Shutdown" is already removed in 3.7.x. IIRC Marc-Andre was against
> removing "Force Shutdown" so I'd like to hear what he has to say on this.

not much, as you said, force shutdown has already been moved.

Fullscreen was in the original design, iirc, ask the designers.
Comment 3 Jakub Steiner 2013-01-07 22:18:07 UTC 
I agree all of these are in the context of the VM/window. 

For purity's sake, even fullscreen, that was originally put in the app menu in the design, should probably find space in a toolbar.
Comment 4 Zeeshan Ali 2013-01-08 01:40:56 UTC 
Created attachment 232949 [details] [review]
app: Remove 'fullscreen' & 'properties' from global menu

These are VM-specific and don't really belong in the global menu.
Comment 5 Alexander Larsson 2013-01-11 10:44:18 UTC 
Review of attachment 232949 [details] [review]:

This just removes the actions, not the menus, like in:
            display_section.append (_("Properties"), "app.display.properties");
            display_section.append (_("Fullscreen"), "app.display.fullscreen");
Comment 6 Zeeshan Ali 2013-01-11 14:14:54 UTC 
(In reply to comment #5)
> Review of attachment 232949 [details] [review]:
> 
> This just removes the actions, not the menus, like in:
>             display_section.append (_("Properties"), "app.display.properties");
>             display_section.append (_("Fullscreen"), "app.display.fullscreen");

Oh? in practice, I didn't see the menu items after this patch though. weird.
Comment 7 Zeeshan Ali 2013-01-11 15:13:46 UTC 
Created attachment 233236 [details] [review]
app: Remove 'fullscreen' & 'properties' from global menu

These are VM-specific and don't really belong in the global menu.
Comment 8 Alexander Larsson 2013-01-22 16:52:12 UTC 
Review of attachment 233236 [details] [review]:

ack
Comment 9 Zeeshan Ali 2013-01-22 20:02:29 UTC 
Attachment 233236 [details] pushed as 6b9f9bd - app: Remove 'fullscreen' & 'properties' from global menu