GNOME Bugzilla – Bug 690240
encodebin: remove test of encoder name vs preset name
Last modified: 2012-12-18 16:50:42 UTC
Created attachment 231606 [details] [review] encodebin: remove test of encoder name vs preset name Commit 7358cba made use of the preset_name though it also added a comparison between the preset name and the factory object name (the encoder name). As those rarely matches the test fails for cheese vp8enc factory name vs preset "Profile Realtime".
Just came accross this as well when trying the encodebin-using test case from bug #690132 . Not entirely sure the code makes sense in its present form. Also looks like it might break existing code. Raising priority for now.
Related commits: http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=6a7f6889397206d23f5af8ba689045c727e94b39 http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=7358cba01709a4b47ab0b167f102a68ac0aee09f http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=12aef5f47df241695082a9e826dcb3e343419a0d
Ok, so the idea is that the preset is the factory name of the GstElement that implement the GstPreset interface, and the preset_name is the actual preset name of the preset. I know it sensibly changes the behavior but it also lets real control to the user over what element should be used and what preset to apply on that element. I can just revert that if the change in behavior is not acceptable.
Btw, I would just revert all my changes instead of applying the proposed patch as the patch makes my previous patches useless.
Created attachment 231631 [details] [review] Patch to avoid changing the behaviour leting the user choose what preset element should be used
I think I got it right now . Thanks . Will send a patch to cheese with this change : "encoder name" as preset and "profile" as preset_name. Sorry for the noise.
Alban I think I should rather apply my last patch as I should not have changed the behaviour. Tim what do you think?
Looks better
Ok, merged. Really sorry about that. commit e79f0e801eccabe245b4ba956c036c4130ffc791 Author: Thibault Saunier <thibault.saunier@collabora.com> Date: Sat Dec 15 14:43:40 2012 -0300 encodebing: Use the preset_name as the factory name and preset as the name of the preset The naming is not perfect, but at least we can keep the exact same behaviour as before.