After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690216 - Epiphany crashes if the "window-close-symbolic" icon is not found
Epiphany crashes if the "window-close-symbolic" icon is not found
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-14 16:48 UTC by Alberto Garcia
Modified: 2012-12-14 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.11 KB, patch)
2012-12-14 18:58 UTC, Alberto Garcia 		reviewed Details | Review
Patch v2 (1.55 KB, patch)
2012-12-14 19:59 UTC, Alberto Garcia 		accepted-commit_now Details | Review

Description Alberto Garcia 2012-12-14 16:48:36 UTC 
This icon is loaded by EphyRemovablePixbufRenderer and is assumed to
exist. If it doesn't, ephy_removable_pixbuf_renderer_render() crashes
in gtk_render_icon().
Comment 1 Alberto Garcia 2012-12-14 18:58:03 UTC 
Created attachment 231583 [details] [review]
Patch
Comment 2 Claudio Saavedra 2012-12-14 19:07:26 UTC 
Review of attachment 231583 [details] [review]:

::: lib/widgets/ephy-removable-pixbuf-renderer.c
@@ +231,3 @@
+  if (!self->priv->close_icon)
+    {
+      g_warning ("window-close-symbolic icon not found");

Maybe you should add a GError to the gtk_icon_theme_load_icon() call and print that message instead?
Comment 3 Alberto Garcia 2012-12-14 19:59:22 UTC 
Created attachment 231589 [details] [review]
Patch v2

(In reply to comment #2)
> Maybe you should add a GError to the gtk_icon_theme_load_icon() call
> and print that message instead?

You're good.
Comment 4 Claudio Saavedra 2012-12-14 20:10:10 UTC 
Review of attachment 231589 [details] [review]:

Please commit after fixing the style.

::: lib/widgets/ephy-removable-pixbuf-renderer.c
@@ +231,3 @@
+
+  if (error != NULL)
+    {

Braces don't go in a new line; check HACKING :)