After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690174 - workspaces-view: make sure to add spacing between view and controls
workspaces-view: make sure to add spacing between view and controls
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-13 19:23 UTC by Cosimo Cecchi
Modified: 2012-12-15 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspaces-view: make sure to add spacing between view and controls (2.85 KB, patch)
2012-12-13 19:23 UTC, Cosimo Cecchi 		committed Details | Review
message-tray: use a style class for summary-mode actor (1.70 KB, patch)
2012-12-13 22:53 UTC, Cosimo Cecchi 		committed Details | Review
overview: don't clone the whole message tray when layouting (1.24 KB, patch)
2012-12-13 22:53 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-12-13 19:23:06 UTC 
This is a regression spotted by Allan from the "overview as boxlayouts" commit.
Comment 1 Cosimo Cecchi 2012-12-13 19:23:08 UTC 
Created attachment 231503 [details] [review]
workspaces-view: make sure to add spacing between view and controls

The thumbnail controls are not a separate actor in the overview group
yet, so we need to ensure a spacing between them and the workspaces
view.
Instead of exporting the overview spacing, just add a temporary style
class to the workspaces-view actor for it. It will be removed in the
future when we change the layout of overview elements.
Comment 2 Giovanni Campagna 2012-12-13 19:26:31 UTC 
Opps, I have filed bug 690171 for this, with a different patch...
Comment 3 Cosimo Cecchi 2012-12-13 22:53:15 UTC 
Created attachment 231524 [details] [review]
message-tray: use a style class for summary-mode actor

We want to use the same style class for the message tray ghost.
Comment 4 Cosimo Cecchi 2012-12-13 22:53:19 UTC 
Created attachment 231525 [details] [review]
overview: don't clone the whole message tray when layouting

The message tray actor also includes notifications themselves. We want
our ghost to be sized as the base part of the tray instead.
Just make sure to use the same style class as the base actor then, as
its height is specified by the CSS.
Comment 5 Cosimo Cecchi 2012-12-13 22:53:52 UTC 
Another couple of regression fixes from "overview as boxlayouts".
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-13 22:55:58 UTC 
Review of attachment 231524 [details] [review]:

OK
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-12-13 22:56:16 UTC 
Review of attachment 231525 [details] [review]:

Sure.
Comment 8 Giovanni Campagna 2012-12-13 22:56:36 UTC 
Review of attachment 231524 [details] [review]:

OK
Comment 9 Giovanni Campagna 2012-12-13 22:57:22 UTC 
Wow, a human race condition!
Comment 10 Cosimo Cecchi 2012-12-13 22:58:12 UTC 
Attachment 231524 [details] pushed as bdf0a6f - message-tray: use a style class for summary-mode actor
Attachment 231525 [details] pushed as e89ce73 - overview: don't clone the whole message tray when layouting

Thanks, keeping it open for the last patch.
Comment 11 Giovanni Campagna 2012-12-15 14:20:59 UTC 
Review of attachment 231503 [details] [review]:

Ok, let's do this.
Comment 12 Cosimo Cecchi 2012-12-15 19:15:14 UTC 
Attachment 231503 [details] pushed as a0e340f - workspaces-view: make sure to add spacing between view and controls

Thanks Giovanni!