After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690149 - [mpeg4videoparse] support divx and add GMC info in caps
[mpeg4videoparse] support divx and add GMC info in caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.0.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-13 10:56 UTC by Arnaud Vrac
Modified: 2012-12-13 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mpeg4videoparse: handle divx caps (1.98 KB, patch)
2012-12-13 10:56 UTC, Arnaud Vrac
committed Details | Review
mpeg4videoparse: export number of sprite warping points in caps (1.09 KB, patch)
2012-12-13 10:56 UTC, Arnaud Vrac
committed Details | Review

Description Arnaud Vrac 2012-12-13 10:56:05 UTC
Created attachment 231463 [details] [review]
mpeg4videoparse: handle divx caps

Hi,

I have attached two patches to allow better integration with hardware mpeg4 decoders.

The first patch allows parsing DivX videos, since they are standard MPEG-4 part 2 videos. We probably could remove the divx caps altogether and just use video/mpeg caps, just like Tim did for XviD.

The second patch exports the number of sprite warping points when GMC is enabled. Hardware decoders usually only support 1 sprite warping point, so it allows to filter out those videos or decode them in software instead. Wikipedia states: "Xvid specifies three warp points for its implementation of global motion compensation as opposed to the single warp point implementation of DivX", but I've seen DivX files with 2 warping points, so that's why we also need to parse DivX videos.
Comment 1 Arnaud Vrac 2012-12-13 10:56:30 UTC
Created attachment 231464 [details] [review]
mpeg4videoparse: export number of sprite warping points in caps
Comment 2 Sebastian Dröge (slomo) 2012-12-13 11:01:42 UTC
commit 0d15c8a7a59e11ef3c83fcc9363f074b7882997f
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Thu Dec 13 11:47:57 2012 +0100

    mpeg4videoparse: export number of sprite warping points in caps
    
    This allows filtering out videos for hardware decoders that do not
    support GMC at all or only support a limited number of sprite warping
    points (usually 1).

commit 07c2a82e5d471794c03e89ca2e0dacd4ed544d23
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Thu Dec 13 11:43:09 2012 +0100

    mpeg4videoparse: handle divx caps
    
    DivX 4/5 are MPEG4 part 2 videos, so they can be parsed by this plugin.