After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689954 - Fix some issues I found with the PopupMenuManager/GrabHelper port
Fix some issues I found with the PopupMenuManager/GrabHelper port
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-10 09:01 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-10 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
panel: Remove a dead check (881 bytes, patch)
2012-12-10 09:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Complete the dummy fake menu (981 bytes, patch)
2012-12-10 09:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Display the proper animations for popup menus (1.22 KB, patch)
2012-12-10 09:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Don't slide menus when we're changing them (3.21 KB, patch)
2012-12-10 09:02 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-10 09:01:59 UTC 
There were bound to be some...
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-10 09:02:01 UTC 
Created attachment 231116 [details] [review]
panel: Remove a dead check

With the dummy menu item now in place, we will always have a menu.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-10 09:02:04 UTC 
Created attachment 231118 [details] [review]
popupMenu: Complete the dummy fake menu

"toggle" is used when clicking on the source actor. As we don't
actually have a menu, we don't want to actually take any grabs
through the menu system, so make it a no-op rather than have it
toggle the menu state.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-10 09:02:07 UTC 
Created attachment 231119 [details] [review]
popupMenu: Display the proper animations for popup menus

BoxPointer's API changed to take a BoxPointer.PopupAnimation
enumeration value, but the code was accidentally replaced with
older code when porting the PopupMenuManager code to GrabHelper.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-10 09:02:10 UTC 
Created attachment 231120 [details] [review]
popupMenu: Don't slide menus when we're changing them

As calling close() will drop the grab, we were inadverdently
re-closing menus, causing them to re-animate with a full animation.
Comment 5 Rui Matos 2012-12-10 13:24:11 UTC 
Review of attachment 231118 [details] [review]:

Ok
Comment 6 Rui Matos 2012-12-10 13:24:18 UTC 
Review of attachment 231116 [details] [review]:

++
Comment 7 Rui Matos 2012-12-10 13:25:51 UTC 
Review of attachment 231119 [details] [review]:

Yep
Comment 8 Rui Matos 2012-12-10 13:52:07 UTC 
Review of attachment 231120 [details] [review]:

Makes sense
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-12-10 19:38:51 UTC 
Attachment 231116 [details] pushed as 04bf75d - panel: Remove a dead check
Attachment 231118 [details] pushed as 13a2b28 - popupMenu: Complete the dummy fake menu
Attachment 231119 [details] pushed as ca2ee22 - popupMenu: Display the proper animations for popup menus
Attachment 231120 [details] pushed as b42af9a - popupMenu: Don't slide menus when we're changing them