After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689732 - osxvideosink can't resize Cocoa window on receiving caps
osxvideosink can't resize Cocoa window on receiving caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.31
Other Linux
: Normal normal
: 1.0.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-05 20:00 UTC by Alexey Chernov
Modified: 2012-12-10 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch solving resize problem in osxvideosink (551 bytes, patch)
2012-12-08 11:40 UTC, Alexey Chernov 		committed Details | Review

Description Alexey Chernov 2012-12-05 20:00:27 UTC 
Resize function of osxvideosink doesn't actually work on receiving updated caps. There's minor problem in source code, I've got a patch that solves the problem so I'll add it later.
Comment 1 Tim-Philipp Müller 2012-12-08 00:13:41 UTC 
> I've got a patch that solves the problem so I'll add it later.

Could you attach it please?
Comment 2 Alexey Chernov 2012-12-08 11:40:43 UTC 
Created attachment 231029 [details] [review]
The patch solving resize problem in osxvideosink
Comment 3 Alexey Chernov 2012-12-08 11:42:07 UTC 
Yes, sure, here it is. As I said, the fix is quite small, but still I would like to thank my employer, Neosphere LLC, for permission to share it.

The patch is against latest git version of osxvideo plugin.
Comment 4 Sebastian Dröge (slomo) 2012-12-10 11:49:26 UTC 
commit d4622c974f330afc44435e1327feee99c64e870d
Author: Alexey Chernov <4ernov@gmail.com>
Date:   Mon Dec 10 11:44:26 2012 +0000

    osxvideosink: Fix resizing the Cocoa window on receiving new caps
    
    Fixes bug #689732.
Comment 5 Alexey Chernov 2012-12-10 17:47:47 UTC 
Thanks for merging, Sebastian!