After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689684 - wacom: small code clean-up, use the local vars when we set them
wacom: small code clean-up, use the local vars when we set them
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Olivier Fourdan
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-05 09:33 UTC by Olivier Fourdan
Modified: 2013-01-17 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.10 KB, patch)
2012-12-05 09:35 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2012-12-05 09:33:25 UTC 
In several places in cc-wacom-page.c, the code sets a local var "priv" to access the private fields of the CcWacomPage "page->priv" but still uses "page->priv" which somehow defeats the need for a local variable...

Trivial patch attached.
Comment 1 Olivier Fourdan 2012-12-05 09:35:07 UTC 
Created attachment 230736 [details] [review]
Proposed patch
Comment 2 Bastien Nocera 2012-12-05 10:44:03 UTC 
Review of attachment 230736 [details] [review]:

++