GNOME Bugzilla – Bug 689672
media-keys: make 'search' launch shell search instead of gnome-search-tool
Last modified: 2013-05-17 16:57:32 UTC
It makes a lot more sense for the 'search' shortcut to bring up the gnome-shell overview and focus the search entry, than to launch gnome-search-tool.
That's basically what <super> and <alt>f1 do (minus explicitly focusing the search entry, but keyboard input is redirected to the entry anyway ...), so is it really that useful to add yet another alias? Maybe we should just retire the shortcut?
(In reply to comment #1) > That's basically what <super> and <alt>f1 do (minus explicitly focusing the > search entry, but keyboard input is redirected to the entry anyway ...), so is > it really that useful to add yet another alias? Maybe we should just retire the > shortcut? Both combinations are toggles, and they don't focus the text entry (eg. the OSK wouldn't show up if I pressed this combination).
I wasn't considering the OSK case, good point.
this would still be nice to have
It's waiting on the shell implementation of the necessary D-Bus API. The implementation on the g-s-d side is trivial.
Heh, the implementation on the shell side is trivial as well :-)
Created attachment 244554 [details] [review] media-keys: Rename osd_proxy to shell_proxy We'll also use it for other things.
Created attachment 244555 [details] [review] media-keys: Show shell search for search button
Review of attachment 244554 [details] [review]: Looks good, but you should rename osd_cancellable as well
Review of attachment 244555 [details] [review]: Yes.
Created attachment 244558 [details] [review] media-keys: Rename osd_proxy to shell_proxy We'll also use it for other things. Also rename osd_cancellable to match.
Review of attachment 244558 [details] [review]: Yes, but remember to rename it in the other patch as well :)
Created attachment 244559 [details] [review] media-keys: Show shell search for search button
Pushed to gnome-3-8 and master. Attachment 244558 [details] pushed as 2b6cf68 - media-keys: Rename osd_proxy to shell_proxy Attachment 244559 [details] pushed as 36626bb - media-keys: Show shell search for search button